From 007ade81a044a15a6d08590a65fac57f74e84ba0 Mon Sep 17 00:00:00 2001 From: Sriram Hariharan Date: Mon, 6 Mar 2023 00:23:20 -0600 Subject: [PATCH] minor styling --- src/shared/types/Course.ts | 1 + .../components/injected/CoursePopup/CoursePopup.module.scss | 6 +++++- src/views/components/injected/CoursePopup/CoursePopup.tsx | 3 +-- todo.md | 5 ++--- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/shared/types/Course.ts b/src/shared/types/Course.ts index cf2e0d13..ce930deb 100644 --- a/src/shared/types/Course.ts +++ b/src/shared/types/Course.ts @@ -74,6 +74,7 @@ export class Course { constructor(course: Course | Serialized) { Object.assign(this, course); + this.schedule = new CourseSchedule(course.schedule); } /** diff --git a/src/views/components/injected/CoursePopup/CoursePopup.module.scss b/src/views/components/injected/CoursePopup/CoursePopup.module.scss index 0e3ad49b..72cf2d27 100644 --- a/src/views/components/injected/CoursePopup/CoursePopup.module.scss +++ b/src/views/components/injected/CoursePopup/CoursePopup.module.scss @@ -13,7 +13,7 @@ height: auto; color: white; padding: 12px; - margin: 40px; + margin: 50px 20px; align-items: center; justify-content: center; @@ -26,5 +26,9 @@ margin-left: 8px; } } + + .instructors { + margin-top: 8px; + } } } diff --git a/src/views/components/injected/CoursePopup/CoursePopup.tsx b/src/views/components/injected/CoursePopup/CoursePopup.tsx index 4d63fc23..5f2822eb 100644 --- a/src/views/components/injected/CoursePopup/CoursePopup.tsx +++ b/src/views/components/injected/CoursePopup/CoursePopup.tsx @@ -33,11 +33,10 @@ export default function CoursePopup({ course, onClose }: Props) { #{course.uniqueId} - + {course.getInstructorString({ prefix: 'with ', format: 'first_last', - max: 3, })} diff --git a/todo.md b/todo.md index 32f15724..78187da9 100644 --- a/todo.md +++ b/todo.md @@ -7,9 +7,9 @@ Last Updated: 03/4/2023 - [x] scraping course information - [x] injecting plus header and buttons - [x] auto loading next pages -- [ ] showing course popup +- [x] showing course popup - [ ] RMP, eCis, Textbook, and Syllabus buttons -- [ ] displaying professor information on popup +- [x] displaying professor information on popup - [ ] saving courses - [ ] Multiple schedule support - [ ] Browser Action Popup @@ -26,7 +26,6 @@ Last Updated: 03/4/2023 - [ ] Grade distribution - [ ] Course description - [ ] Highlight and use rich text to make course description more readable -- [ ] auto load - [ ] calendar - [ ] calendar file export - [ ] save as png