added ExtensionRoot for consistent styling across injected components, and added a bunch of comments for all the added types and classes

This commit is contained in:
Sriram Hariharan
2023-03-04 21:10:12 -06:00
parent 46282a0406
commit 070c8ea486
8 changed files with 176 additions and 25 deletions

View File

@@ -5,6 +5,8 @@ import useInfiniteScroll from '../hooks/useInfiniteScroll';
import { CourseScraper } from '../lib/courseCatalog/CourseScraper';
import { populateSearchInputs } from '../lib/courseCatalog/populateSearchInputs';
import { SiteSupport } from '../lib/getSiteSupport';
import ExtensionRoot from './common/ExtensionRoot/ExtensionRoot';
import CoursePopup from './injected/CoursePopup/CoursePopup';
import TableHead from './injected/TableHead';
import TableRow from './injected/TableRow';
@@ -35,22 +37,27 @@ export default function CourseCatalogMain({ support }: Props) {
setRows(rows);
}, []);
const handleRowButtonClick = (course: Course) => {
const handleRowButtonClick = (course: Course) => () => {
setSelectedCourse(course);
};
const handleClearSelectedCourse = () => {
setSelectedCourse(null);
};
return (
<div>
<ExtensionRoot>
<TableHead>Plus</TableHead>
{rows.map(row => (
<TableRow
element={row.rowElement}
course={row.course}
support={support}
onClick={handleRowButtonClick}
onClick={handleRowButtonClick(row.course)}
/>
))}
{selectedCourse && <CoursePopup course={selectedCourse} onClose={handleClearSelectedCourse} />}
{isScrolling && <div>Scrolling...</div>}
</div>
</ExtensionRoot>
);
}

View File

@@ -1,5 +1,6 @@
import React from 'react';
import ExtensionRoot from './common/ExtensionRoot/ExtensionRoot';
export default function PopupMain() {
return <div>popup</div>;
return <ExtensionRoot>Popup</ExtensionRoot>;
}

View File

@@ -0,0 +1,12 @@
@import 'src/views/styles/base.module.scss';
.extensionRoot {
font-family: 'Inter' !important;
color: #303030;
-webkit-box-sizing: border-box;
box-sizing: border-box;
font-family: Inter, sans-serif;
font-weight: 300;
font-size: 14px;
line-height: 18px;
}

View File

@@ -0,0 +1,16 @@
import React from 'react';
import styles from './ExtensionRoot.module.scss';
interface Props {
testId?: string;
}
/**
* A wrapper component for the extension elements that adds some basic styling to them
*/
export default function ExtensionRoot(props: React.PropsWithChildren<Props>) {
return (
<div className={styles.extensionRoot} data-testid={props.testId}>
{props.children}
</div>
);
}

View File

@@ -1,16 +1,19 @@
import React from 'react';
import { Course } from 'src/shared/types/Course';
import { Button } from '../../common/Button/Button';
import styles from './CoursePopup.module.scss';
interface Props {
course: Course;
onClose: () => void;
}
export default function CoursePopup({ course }: Props) {
export default function CoursePopup({ course, onClose }: Props) {
return (
<div>
<h1>{course.fullName}</h1>
<p>{course.description}</p>
<Button onClick={onClose}>Close</Button>
</div>
);
}