diff --git a/src/shared/types/CourseMeeting.ts b/src/shared/types/CourseMeeting.ts index 521f89ff..51f400bb 100644 --- a/src/shared/types/CourseMeeting.ts +++ b/src/shared/types/CourseMeeting.ts @@ -108,7 +108,7 @@ export class CourseMeeting { } startTimeString += startMinute === 0 ? ':00' : `:${startMinute}`; - startTimeString += startHour >= 12 ? ' p.m.' : ' a.m.'; + startTimeString += startHour >= 12 ? 'pm' : 'am'; if (endHour === 0) { endTimeString = '12'; @@ -117,13 +117,9 @@ export class CourseMeeting { } else { endTimeString = `${endHour}`; } - endTimeString += endMinute === 0 ? ':00' : `:${endMinute}`; - endTimeString += endHour >= 12 ? ' p.m.' : ' a.m.'; - if (options.capitalize) { - startTimeString = startTimeString.toUpperCase(); - endTimeString = endTimeString.toUpperCase(); - } + endTimeString += endMinute === 0 ? ':00' : `:${endMinute}`; + endTimeString += endHour >= 12 ? 'pm' : 'am'; return `${startTimeString} ${options.separator} ${endTimeString}`; } @@ -135,8 +131,6 @@ export class CourseMeeting { type TimeStringOptions = { /** the separator between the start and end times */ separator: string; - /** capitalizes the AM/PM */ - capitalize?: boolean; }; /** diff --git a/src/stories/components/calendar/CalendarCourseCell.stories.tsx b/src/stories/components/calendar/CalendarCourseCell.stories.tsx index f5c31388..b41acb65 100644 --- a/src/stories/components/calendar/CalendarCourseCell.stories.tsx +++ b/src/stories/components/calendar/CalendarCourseCell.stories.tsx @@ -30,7 +30,7 @@ const meta = { courseDeptAndInstr: ExampleCourse.department, className: ExampleCourse.number, status: ExampleCourse.status, - timeAndLocation: ExampleCourse.schedule.meetings[0]!.getTimeString({ separator: '-' }), + timeAndLocation: ExampleCourse.schedule.meetings[0]!.getTimeString({ separator: '–' }), colors: getCourseColors('emerald', 500), }, diff --git a/src/views/components/calendar/CalendarCourseCell.tsx b/src/views/components/calendar/CalendarCourseCell.tsx index 1f7cdd9a..971dc84c 100644 --- a/src/views/components/calendar/CalendarCourseCell.tsx +++ b/src/views/components/calendar/CalendarCourseCell.tsx @@ -101,7 +101,7 @@ export default function CalendarCourseCell({ {courseDeptAndInstr} {timeAndLocation && ( - + {timeAndLocation} )} diff --git a/src/views/components/common/Text/Text.module.scss b/src/views/components/common/Text/Text.module.scss index c7d64590..547542f5 100644 --- a/src/views/components/common/Text/Text.module.scss +++ b/src/views/components/common/Text/Text.module.scss @@ -34,7 +34,7 @@ font-size: 0.6875rem; font-weight: 400; letter-spacing: 0; - line-height: 100%; /* 0.6875rem */ + line-height: 0.775rem; } .h3 { @@ -58,7 +58,7 @@ } .h1-course { - font-size: 1rem; + font-size: 0.9375rem; font-weight: 550; text-transform: capitalize; letter-spacing: 0; diff --git a/src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx b/src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx index cf205e51..6ba37f59 100644 --- a/src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx +++ b/src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx @@ -168,7 +168,7 @@ export default function HeadingAndActions({ course, activeSchedule, onClose }: H
{schedule.meetings.map(meeting => { const daysString = meeting.getDaysString({ format: 'long', separator: 'long' }); - const timeString = meeting.getTimeString({ separator: ' to ', capitalize: false }); + const timeString = meeting.getTimeString({ separator: ' to ' }); return ( = midnightIndex ? startTime - normalizingTimeFactor : startTime; const normalizedEndTime = endTime >= midnightIndex ? endTime - normalizingTimeFactor : endTime; + const courseDuration = normalizedEndTime - normalizedStartTime; + let timeAndLocation = `${time}`; + if (location) { + if (courseDuration > oneHour) { + timeAndLocation += `\n${location.building} ${location.room}`; + } else { + timeAndLocation += `, ${location.building} ${location.room}`; + } + } return days.map(day => ({ calendarGridPoint: {