DerexXD/UT-Registration-Plus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: fixed issues involving course meeting objects not being recognized as course meeting objects (#132)

Browse Source 
* fix: coursemeeting objects now created properly. course popup works on calendar

* refactor: removed duplicated getTimeString method in useFlattenedHook

* refactor: meeting constructor

---------

Co-authored-by: Razboy20 <razboy20@gmail.com>
This commit is contained in:
Som Gupta
2024-03-09 20:21:38 -06:00
committed by GitHub
parent c51e6881d1
commit 3406e9a0e2
4 changed files with 20 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared/types/CourseSchedule.ts
View File

@@ -7,13 +7,17 @@ import { CourseMeeting, DAY_MAP } from './CourseMeeting';
* This represents the schedule for a course, which includes all the meeting times for the course, as well as helper functions for parsing, serializing, and deserializing the schedule
*/
export class CourseSchedule {
meetings: CourseMeeting[] = [];
meetings: CourseMeeting[];
constructor(courseSchedule?: Serialized<CourseSchedule>) {
if (!courseSchedule) {
return;
}
Object.assign(this, courseSchedule);
this.meetings = [];
for (let meeting of courseSchedule.meetings) {
this.meetings.push(new CourseMeeting(meeting));
}
}
/**

22
src/shared/types/UserSchedule.ts
View File

@@ -10,22 +10,12 @@ export class UserSchedule {
name: string;
hours: number;
constructor(schedule: Serialized<UserSchedule>);
constructor(courses: Course[], name: string, hours: number);
constructor(coursesOrSchedule: Course[] | Serialized<UserSchedule>, name?: string, hours?: number) {
if (Array.isArray(coursesOrSchedule)) {
this.courses = coursesOrSchedule;
this.name = name || '';
this.hours = hours || 0;
} else {
this.courses = coursesOrSchedule?.courses.map(c => new Course(c)) || [];
this.name = coursesOrSchedule?.name || 'new schedule';
this.hours = 0;
if (this.courses && this.courses.length > 0) {
for (const course of this.courses) {
this.hours += course.creditHours;
}
}
constructor(schedule: Serialized<UserSchedule>) {
this.courses = schedule.courses.map(c => new Course(c));
this.name = schedule.name;
this.hours = 0;
for (const course of this.courses) {
this.hours += course.creditHours;
}
}