DerexXD/UT-Registration-Plus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: grade dist when no instructor (#269)

Browse Source
This commit is contained in:
Samuel Gunter
2024-10-04 21:39:30 -05:00
committed by GitHub
parent c2cab407f3
commit 6a363aeb5c
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/views/lib/database/queryDistribution.ts
View File

@@ -1,5 +1,6 @@
import type { Course, Semester } from '@shared/types/Course'; import type { Course, Semester } from '@shared/types/Course';
import type { CourseSQLRow, Distribution } from '@shared/types/Distribution'; import type { CourseSQLRow, Distribution } from '@shared/types/Distribution';
import type { QueryExecResult } from 'sql.js';
import { initializeDB } from './initializeDB'; import { initializeDB } from './initializeDB';
@@ -20,9 +21,15 @@ export async function queryAggregateDistribution(course: Course): Promise<[Distr
const db = await initializeDB(); const db = await initializeDB();
const [query, params] = generateQuery(course, null, true); const [query, params] = generateQuery(course, null, true);
let res = db.exec(query, params)?.[0]; let res: QueryExecResult | undefined;
let instructorIncluded = true; let instructorIncluded = params[':instructor_last'] !== undefined;
if (!res?.columns?.length) { if (instructorIncluded) {
// Only check for data on an instructor if the course has an instructor
res = db.exec(query, params)?.[0];
}
if (!instructorIncluded || !res?.columns?.length) {
// Either no instructor for the class, or no data for the instructor
instructorIncluded = false; instructorIncluded = false;
const [queryWithoutInstructor, paramsWithoutInstructor] = generateQuery(course, null, false); const [queryWithoutInstructor, paramsWithoutInstructor] = generateQuery(course, null, false);
res = db.exec(queryWithoutInstructor, paramsWithoutInstructor)?.[0]; res = db.exec(queryWithoutInstructor, paramsWithoutInstructor)?.[0];