From 7760e3acf4ee9c5981ea585b287d147e6368cbcf Mon Sep 17 00:00:00 2001 From: Som Gupta <78577376+knownotunknown@users.noreply.github.com> Date: Mon, 11 Mar 2024 23:59:15 -0500 Subject: [PATCH] refactor: doesn't crash tab, and doesn't cause errors (#143) * refactor: doesn't crash tab, and doesn't cause errors * Revert "fix: options page (#131)" This reverts commit dc100b5d3ac1db5f1dc011ea2536c286f56fa55b. * refactor: Simplify CourseSchedule constructor * refactor: Refactor CourseSchedule constructor (again) * Reapply "fix: options page (#131)" This reverts commit 969c5a234f4e0c071e81da0f70b35feca13b63de. --------- Co-authored-by: Razboy20 --- src/shared/types/CourseSchedule.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/shared/types/CourseSchedule.ts b/src/shared/types/CourseSchedule.ts index 098c8fdd..0bea828c 100644 --- a/src/shared/types/CourseSchedule.ts +++ b/src/shared/types/CourseSchedule.ts @@ -10,14 +10,12 @@ export class CourseSchedule { meetings: CourseMeeting[] = []; constructor(courseSchedule?: Serialized) { - if (!courseSchedule) { + if (!courseSchedule || courseSchedule.meetings === undefined) { + this.meetings = []; return; } - Object.assign(this, courseSchedule); - this.meetings = []; - for (let meeting of courseSchedule.meetings) { - this.meetings.push(new CourseMeeting(meeting)); - } + + this.meetings = courseSchedule.meetings.map(meeting => new CourseMeeting(meeting)); } /**