From 8de88d6ad7d4c2b5c3aa08e1efc59f7226b40c6b Mon Sep 17 00:00:00 2001 From: Rishthegreat <76021793+Rishthegreat@users.noreply.github.com> Date: Sun, 27 Oct 2024 17:11:51 -0500 Subject: [PATCH] fix(ui): main popup now shows 0 for empty schedule (#395) --- src/pages/background/background.ts | 8 ++------ src/shared/util/updateBadgeText.ts | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/pages/background/background.ts b/src/pages/background/background.ts index 9bfcd08f..e64d3913 100644 --- a/src/pages/background/background.ts +++ b/src/pages/background/background.ts @@ -59,15 +59,11 @@ messageListener.listen(); UserScheduleStore.listen('schedules', async schedules => { const index = await UserScheduleStore.get('activeIndex'); const numCourses = schedules.newValue[index]?.courses?.length; - if (!numCourses) return; - - updateBadgeText(numCourses); + updateBadgeText(numCourses || 0); }); UserScheduleStore.listen('activeIndex', async ({ newValue }) => { const schedules = await UserScheduleStore.get('schedules'); const numCourses = schedules[newValue]?.courses?.length; - if (!numCourses) return; - - updateBadgeText(numCourses); + updateBadgeText(numCourses || 0); }); diff --git a/src/shared/util/updateBadgeText.ts b/src/shared/util/updateBadgeText.ts index a28c086f..f10de1a3 100644 --- a/src/shared/util/updateBadgeText.ts +++ b/src/shared/util/updateBadgeText.ts @@ -14,7 +14,7 @@ export const BADGE_LIMIT = 10; */ export default function updateBadgeText(value: number): void { let badgeText = ''; - if (value > 0) { + if (value >= 0) { if (value > BADGE_LIMIT) { badgeText = `${BADGE_LIMIT}+`; } else {