feat: enable TS strict mode (#168)

* feat: enable TS strict mode * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: colors bug with default * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: text type errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors - add definite assignment assertion * fix: strict TS errors - add definite assignment assertion * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix(ESLint): error on no-explicit-any * fix: type annotations for any types * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors (and remove packages) * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * feat: enable React.StrictMode * fix: strict TS errors (done!) * fix: build error * fix: replace no-explicit-any assertions * refactor: cleanup * refactor: more cleanup * style: prettier --------- Co-authored-by: Lukas Zenick <lukas@utexas.edu> Co-authored-by: Razboy20 <razboy20@gmail.com>
2024-03-21 13:19:40 -05:00
parent 0c76052478
commit efed1c0edb
61 changed files with 562 additions and 1309 deletions
--- a/src/pages/background/background.ts
+++ b/src/pages/background/background.ts
@@ -44,7 +44,7 @@ messageListener.listen();

 UserScheduleStore.listen('schedules', async schedules => {
    const index = await UserScheduleStore.get('activeIndex');
-    const numCourses = schedules[index]?.courses?.length;
+    const numCourses = schedules.newValue[index]?.courses?.length;
    if (!numCourses) return;

    updateBadgeText(numCourses);
--- a/src/pages/background/handler/CESHandler.ts
+++ b/src/pages/background/handler/CESHandler.ts
@@ -11,7 +11,7 @@ const CESHandler: MessageHandler<CESMessage> = {
            const instructorFirstAndLastName = [instructorFirstName, instructorLastName];
            chrome.scripting.executeScript({
                target: { tabId: tab.id },
-                func: (...instructorFirstAndLastName: String[]) => {
+                func: (...instructorFirstAndLastName: string[]) => {
                    const inputElement = document.getElementById(
                        'ctl00_ContentPlaceHolder1_ViewList_tbxValue'
                    ) as HTMLInputElement | null;
--- a/src/pages/background/handler/calendarBackgroundHandler.ts
+++ b/src/pages/background/handler/calendarBackgroundHandler.ts
@@ -1,21 +1,21 @@
+import type { TabWithId } from '@background/util/openNewTab';
 import openNewTab from '@background/util/openNewTab';
 import { tabs } from '@shared/messages';
 import type { CalendarBackgroundMessages } from '@shared/messages/CalendarMessages';
 import type { MessageHandler } from 'chrome-extension-toolkit';

 const getAllTabInfos = async () => {
-    const openTabs = await chrome.tabs.query({});
+    const openTabs = (await chrome.tabs.query({})).filter((tab): tab is TabWithId => tab.id !== undefined);
    const results = await Promise.allSettled(openTabs.map(tab => tabs.getTabInfo(undefined, tab.id)));
+
+    type TabInfo = PromiseFulfilledResult<Awaited<ReturnType<typeof tabs.getTabInfo>>>;
    return results
        .map((result, index) => ({ result, index }))
-        .filter(({ result }) => result.status === 'fulfilled')
-        .map(({ result, index }) => {
-            if (result.status !== 'fulfilled') throw new Error('Will never happen, typescript dumb');
-            return {
-                ...result.value,
-                tab: openTabs[index],
-            };
-        });
+        .filter((el): el is { result: TabInfo; index: number } => el.result.status === 'fulfilled')
+        .map(({ result, index }) => ({
+            ...result.value,
+            tab: openTabs[index]!,
+        }));
 };

 const calendarBackgroundHandler: MessageHandler<CalendarBackgroundMessages> = {
@@ -25,17 +25,21 @@ const calendarBackgroundHandler: MessageHandler<CalendarBackgroundMessages> = {

        const allTabs = await getAllTabInfos();

-        const openCalendarTabInfo = allTabs.find(tab => tab.url.startsWith(calendarUrl));
+        const openCalendarTabInfo = allTabs.find(tab => tab.url?.startsWith(calendarUrl));

        if (openCalendarTabInfo !== undefined) {
-            chrome.tabs.update(openCalendarTabInfo.tab.id, { active: true });
-            if (uniqueId !== undefined) await tabs.openCoursePopup({ uniqueId }, openCalendarTabInfo.tab.id);
+            const tabid = openCalendarTabInfo.tab.id;
+
+            chrome.tabs.update(tabid, { active: true });
+            if (uniqueId !== undefined) await tabs.openCoursePopup({ uniqueId }, tabid);
+
            sendResponse(openCalendarTabInfo.tab);
        } else {
            const urlParams = new URLSearchParams();
            if (uniqueId !== undefined) urlParams.set('uniqueId', uniqueId.toString());
            const url = `${calendarUrl}?${urlParams.toString()}`.replace(/\?$/, '');
            const tab = await openNewTab(url);
+
            sendResponse(tab);
        }
    },
--- a/src/pages/background/lib/renameSchedule.ts
+++ b/src/pages/background/lib/renameSchedule.ts
@@ -12,11 +12,8 @@ export default async function renameSchedule(scheduleId: string, newName: string
    if (scheduleIndex === -1) {
        return `Schedule ${scheduleId} does not exist`;
    }
-    // if (schedules.find(schedule => schedule.name === newName)) {
-    //     return `Schedule ${newName} already exists`;
-    // }

-    schedules[scheduleIndex].name = newName;
+    schedules[scheduleIndex]!.name = newName;
    // schedules[scheduleIndex].updatedAt = Date.now();

    await UserScheduleStore.set('schedules', schedules);
--- a/src/pages/background/lib/switchSchedule.ts
+++ b/src/pages/background/lib/switchSchedule.ts
@@ -13,7 +13,8 @@ export default async function switchSchedule(scheduleId: string): Promise<void>
    if (scheduleIndex === -1) {
        throw new Error(`Schedule ${scheduleId} does not exist`);
    }
-    schedules[scheduleIndex].updatedAt = Date.now();
+
+    schedules[scheduleIndex]!.updatedAt = Date.now();

    await UserScheduleStore.set('activeIndex', scheduleIndex);
 }
--- a/src/pages/background/util/openDebugTab.ts
+++ b/src/pages/background/util/openDebugTab.ts
@@ -10,7 +10,7 @@ export async function openDebugTab() {
            DevStore.get('wasDebugTabVisible'),
        ]);

-        const isAlreadyOpen = await (await chrome.tabs.query({})).some(tab => tab.id === debugTabId);
+        const isAlreadyOpen = (await chrome.tabs.query({})).some(tab => tab.id === debugTabId);
        if (isAlreadyOpen) return;

        const tab = await chrome.tabs.create({
--- a/src/pages/background/util/openNewTab.ts
+++ b/src/pages/background/util/openNewTab.ts
@@ -1,10 +1,12 @@
+export type TabWithId = Omit<chrome.tabs.Tab, 'id'> & { id: number };
+
 /**
 * This is a helper function that opens a new tab in the current window, and focuses the window
 * @param tabIndex - the index of the tab to open the new tab at (optional)
 * @returns the tab that was opened
 */
-export default async function openNewTab(url: string, tabIndex?: number): Promise<chrome.tabs.Tab> {
-    const tab = await chrome.tabs.create({ url, index: tabIndex, active: true });
+export default async function openNewTab(url: string, tabIndex?: number): Promise<TabWithId> {
+    const tab = (await chrome.tabs.create({ url, index: tabIndex, active: true })) as TabWithId;
    await chrome.windows.update(tab.windowId, { focused: true });
    return tab;
 }