feat: enable TS strict mode (#168)

* feat: enable TS strict mode * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: colors bug with default * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: text type errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors - add definite assignment assertion * fix: strict TS errors - add definite assignment assertion * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix(ESLint): error on no-explicit-any * fix: type annotations for any types * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors (and remove packages) * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * fix: strict TS errors * feat: enable React.StrictMode * fix: strict TS errors (done!) * fix: build error * fix: replace no-explicit-any assertions * refactor: cleanup * refactor: more cleanup * style: prettier --------- Co-authored-by: Lukas Zenick <lukas@utexas.edu> Co-authored-by: Razboy20 <razboy20@gmail.com>
2024-03-21 13:19:40 -05:00
parent 0c76052478
commit efed1c0edb
61 changed files with 562 additions and 1309 deletions
--- a/src/stories/components/Dropdown.stories.tsx
+++ b/src/stories/components/Dropdown.stories.tsx
@@ -3,6 +3,7 @@ import { UserSchedule } from '@shared/types/UserSchedule';
 import { generateRandomId } from '@shared/util/random';
 import type { Meta, StoryObj } from '@storybook/react';
 import List from '@views/components/common/List/List';
+import type { ScheduleDropdownProps } from '@views/components/common/ScheduleDropdown/ScheduleDropdown';
 import ScheduleDropdown from '@views/components/common/ScheduleDropdown/ScheduleDropdown';
 import ScheduleListItem from '@views/components/common/ScheduleListItem/ScheduleListItem';
 import useSchedules, { getActiveSchedule, switchSchedule } from '@views/hooks/useSchedules';
@@ -49,7 +50,7 @@ const meta: Meta<typeof ScheduleDropdown> = {
            },
        },
    },
-    render: (args: any) => {
+    render: (args: ScheduleDropdownProps) => {
        // eslint-disable-next-line react-hooks/rules-of-hooks
        const [activeSchedule, schedules] = useSchedules();

--- a/src/stories/components/List.stories.tsx
+++ b/src/stories/components/List.stories.tsx
@@ -62,7 +62,7 @@ const generateCourses = (count: number): Course[] => {
            status: Status.WAITLISTED,
            uniqueId: 12345 + i, // Make uniqueId different for each course
            url: 'https://utdirect.utexas.edu/apps/registrar/course_schedule/20242/12345/',
-            colors: tailwindColorways[i],
+            colors: tailwindColorways[i]!,
        });

        courses.push(course);
@@ -86,16 +86,16 @@ const meta = {
    argTypes: {
        gap: { control: 'number' },
    },
-} satisfies Meta<typeof List>;
+} satisfies Meta<typeof List<Course>>;
 export default meta;

-type Story = StoryObj<typeof meta>;
+type Story = StoryObj<Meta<typeof List<Course>>>;

 export const Default: Story = {
    args: {
        draggables: exampleCourses,
        children: generateCourseBlocks,
-        itemKey: (item: Course) => item.uniqueId,
+        itemKey: item => item.uniqueId,
        gap: 12,
    },
    render: args => (
--- a/src/stories/components/Prompt.stories.tsx
+++ b/src/stories/components/Prompt.stories.tsx
@@ -27,7 +27,7 @@ const PromptDialogWithButton = ({ children, ...args }: PromptDialogProps) => {
    const handleClose = () => setIsOpen(false);
    const { title, content } = args;

-    const childrenWithHandleClose: React.ReactElement[] = children.map(child => {
+    const childrenWithHandleClose: React.ReactElement[] = (children ?? []).map(child => {
        if (child.type === Button) {
            return React.cloneElement(child, { onClick: () => handleClose() } as React.HTMLAttributes<HTMLElement>);
        }
--- a/src/stories/components/calendar/CalendarBottomBar.stories.tsx
+++ b/src/stories/components/calendar/CalendarBottomBar.stories.tsx
@@ -87,12 +87,12 @@ export const Default: Story = {
        courses: [
            {
                colors: getCourseColors('pink', 200),
-                courseDeptAndInstr: `${exampleGovCourse.department} ${exampleGovCourse.number} – ${exampleGovCourse.instructors[0].lastName}`,
+                courseDeptAndInstr: `${exampleGovCourse.department} ${exampleGovCourse.number} – ${exampleGovCourse.instructors[0]!.lastName}`,
                status: exampleGovCourse.status,
            },
            {
                colors: getCourseColors('slate', 500),
-                courseDeptAndInstr: `${examplePsyCourse.department} ${examplePsyCourse.number} – ${examplePsyCourse.instructors[0].lastName}`,
+                courseDeptAndInstr: `${examplePsyCourse.department} ${examplePsyCourse.number} – ${examplePsyCourse.instructors[0]!.lastName}`,
                status: examplePsyCourse.status,
            },
        ],
--- a/src/stories/components/calendar/CalendarCourse.stories.tsx
+++ b/src/stories/components/calendar/CalendarCourse.stories.tsx
@@ -16,7 +16,6 @@ const meta = {
    argTypes: {
        course: { control: 'object' },
        meetingIdx: { control: 'number' },
-        rightIcon: { control: 'object' },
    },
 } satisfies Meta<typeof CalendarCourse>;
 export default meta;
--- a/src/stories/components/calendar/CalendarCourseCell.stories.tsx
+++ b/src/stories/components/calendar/CalendarCourseCell.stories.tsx
@@ -1,6 +1,7 @@
 import { Status } from '@shared/types/Course';
 import { getCourseColors } from '@shared/util/colors';
 import type { Meta, StoryObj } from '@storybook/react';
+import type { CalendarCourseCellProps } from '@views/components/calendar/CalendarCourseCell/CalendarCourseCell';
 import CalendarCourseCell from '@views/components/calendar/CalendarCourseCell/CalendarCourseCell';
 import React from 'react';

@@ -20,7 +21,7 @@ const meta = {
        timeAndLocation: { control: { type: 'text' } },
        colors: { control: { type: 'object' } },
    },
-    render: (args: any) => (
+    render: (args: CalendarCourseCellProps) => (
        <div className='w-45'>
            <CalendarCourseCell {...args} />
        </div>
@@ -29,7 +30,7 @@ const meta = {
        courseDeptAndInstr: ExampleCourse.department,
        className: ExampleCourse.number,
        status: ExampleCourse.status,
-        timeAndLocation: ExampleCourse.schedule.meetings[0].getTimeString({ separator: '-' }),
+        timeAndLocation: ExampleCourse.schedule.meetings[0]!.getTimeString({ separator: '-' }),

        colors: getCourseColors('emerald', 500),
    },