fix: fixed bug with course cells after 12 PM extending past midnight (#122)

* Temporarily uninstalling husky cause github desktop has issues with it

* Cleaned up some code. Removed unnecessary state value on injected popup

* Should've fixed popup alignment issue. Still need to integrate course schedule with calendar. Still debugging.

* Updated CalendarGridStories

* Fix: change to ExampleCourse from exampleCourse

* setCourse and calendar header need work

* Update as part of merge

* Fix: fixed build errors

* Fix: Added Todo

* Chore: Cleaned up useFlattenedCourseSchedule hook

* fix: List now keeps track of state when existing items are switched, while adding new items to the end

* Added back husky

* Update src/views/components/calendar/Calendar/Calendar.tsx

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* refactor: added type-safety, destructuring, etc. ready for re-review

* refactor: got rid of ts-ignore in openNewTabFromContentScript

* Update src/views/components/calendar/CalendarHeader/CalenderHeader.tsx

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* refactor: using path aliasing

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* refactor: using path aliasing

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* refactor: using satisfies instead of as

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* refactor: using satisfies instead of as

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

* style: reformatted spacing

* style: eslint import order

* refactor: added new constructor for UserSchedule to avoid passing down null values to child props

* fix: fixed bug with course cell times starting and after 12 PM. commented in CourseMeeting class

* Update src/views/hooks/useFlattenedCourseSchedule.ts

* fix: fixed build errors by removing old apis

* refactor: added type-safety and destructuring

---------

Co-authored-by: doprz <52579214+doprz@users.noreply.github.com>

src/views/hooks/useFlattenedCourseSchedule.ts

@@ -5,6 +5,8 @@ import type { CalendarCourseCellProps } from '@views/components/calendar/Calenda
 
 import useSchedules from './useSchedules';
 
+
+
 const dayToNumber: { [day: string]: number } = {
     Monday: 0,
     Tuesday: 1,
@@ -58,32 +60,31 @@ export function useFlattenedCourseSchedule(): FlattenedCourseSchedule {
         return {
             courseCells: [] as CalendarGridCourse[],
             activeSchedule: new UserSchedule([], 'Something may have went wrong', 0),
-        } as FlattenedCourseSchedule;
+        } satisfies FlattenedCourseSchedule;
     }
 
     if (activeSchedule.courses.length === 0) {
         return {
             courseCells: [] as CalendarGridCourse[],
-            activeSchedule,
+            activeSchedule
         } satisfies FlattenedCourseSchedule;
+
     }
 
     const { courses, name, hours } = activeSchedule;
 
-    const processedCourses = courses
-        .flatMap((course: Course) => {
-            const { status, courseDeptAndInstr, meetings } = extractCourseInfo(course);
-
-            if (meetings.length === 0) {
-                return processAsyncCourses({ courseDeptAndInstr, status, course });
-            }
-
-            return meetings.flatMap((meeting: CourseMeeting) =>
-                processInPersonMeetings(meeting, { courseDeptAndInstr, status, course })
-            );
-        })
-        .sort(sortCourses);
-
+    const processedCourses = courses.flatMap((course: Course) => {
+        const { status, courseDeptAndInstr, meetings } = extractCourseInfo(course);
+    
+        if (meetings.length === 0) {
+            return processAsyncCourses({ courseDeptAndInstr, status, course });
+        }
+    
+        return meetings.flatMap((meeting: CourseMeeting) => 
+            processInPersonMeetings(meeting, { courseDeptAndInstr, status, course })
+        );
+    }).sort(sortCourses);
+    
     return {
         courseCells: processedCourses as CalendarGridCourse[],
         activeSchedule: { name, courses, hours } as UserSchedule,
@@ -105,33 +106,23 @@ function extractCourseInfo(course: Course) {
 /**
  * Function to process each in-person class into its distinct meeting objects for calendar grid
  */
-function processAsyncCourses({
-    courseDeptAndInstr,
-    status,
-    course,
-}: {
-    courseDeptAndInstr: string;
-    status: StatusType;
-    course: Course;
-}) {
-    return [
-        {
-            calendarGridPoint: {
-                dayIndex: 0,
-                startIndex: 0,
-                endIndex: 0,
-            },
-            componentProps: {
-                courseDeptAndInstr,
-                status,
-                colors: {
-                    primaryColor: 'ut-gray',
-                    secondaryColor: 'ut-gray',
-                },
-            },
-            course,
+function processAsyncCourses({ courseDeptAndInstr, status, course }: { courseDeptAndInstr: string, status: StatusType, course: Course }) {
+    return [{
+        calendarGridPoint: {
+            dayIndex: 0,
+            startIndex: 0,
+            endIndex: 0,
         },
-    ] satisfies CalendarGridCourse[];
+        componentProps: {
+            courseDeptAndInstr,
+            status,
+            colors: {
+                primaryColor: 'ut-gray',
+                secondaryColor: 'ut-gray',
+            },
+        },
+        course,
+    }] satisfies CalendarGridCourse[];
 }
 
 /**
@@ -141,13 +132,17 @@ function processInPersonMeetings(
     { days, startTime, endTime, location }: CourseMeeting,
     { courseDeptAndInstr, status, course }
 ) {
+    const midnightIndex = 1440;
+    const normalizingTimeFactor = 720;
     const time = getTimeString({ separator: '-', capitalize: true }, startTime, endTime);
     const timeAndLocation = `${time} - ${location ? location.building : 'WB'}`;
+    let normalizedStartTime = startTime >= midnightIndex ? startTime - normalizingTimeFactor : startTime;
+    let normalizedEndTime = endTime >= midnightIndex ? endTime - normalizingTimeFactor : endTime;
     return days.map(day => ({
         calendarGridPoint: {
             dayIndex: dayToNumber[day],
-            startIndex: convertMinutesToIndex(startTime),
-            endIndex: convertMinutesToIndex(endTime),
+            startIndex: convertMinutesToIndex(normalizedStartTime),
+            endIndex: convertMinutesToIndex(normalizedEndTime),
         },
         componentProps: {
             courseDeptAndInstr,
@@ -165,7 +160,7 @@ function processInPersonMeetings(
 /**
  * Utility function to sort courses for the calendar grid
  */
-function sortCourses(a, b) {
+function sortCourses(a: CalendarGridCourse, b: CalendarGridCourse): number {
     const { dayIndex: dayIndexA, startIndex: startIndexA, endIndex: endIndexA } = a.calendarGridPoint;
     const { dayIndex: dayIndexB, startIndex: startIndexB, endIndex: endIndexB } = b.calendarGridPoint;