Smartcraft-Media-Tech/ntfysh-windows
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 4 Wiki Activity

Add adjustable reconnects and settings revisions #11

Merged
alexhorner merged 1 commits from master into master 2023-12-28 10:14:50 -05:00
Conversation 3 Commits 1 Files Changed 6 +266 -103
alexhorner commented 2023-10-09 16:20:40 -04:00 (Migrated from github.com)
Copy Link

What I have done

  • Allowed changing the reconnect attempt count and delay based on discussed fix #10
  • Settings window tab indexing cleaned up
  • Settings window element names cleaned up
  • Added a revision property to the settings to update settings files with new values safely and correctly populate new defaults
  • Throw correct ArgumentExceptions in palce of InvalidOperationExceptions
  • Rearranged signatures containing CancellationTokens to be consistent with MS's uses, including with default assignment
  • Code comment typos

Testing

Here is a published release which you can post in the Releases section after merging the PR if you'd like:
ntfy.sh Release.zip

# What I have done - Allowed changing the reconnect attempt count and delay based on discussed fix #10 - Settings window tab indexing cleaned up - Settings window element names cleaned up - Added a revision property to the settings to update settings files with new values safely and correctly populate new defaults - Throw correct ArgumentExceptions in palce of InvalidOperationExceptions - Rearranged signatures containing CancellationTokens to be consistent with MS's uses, including with `default` assignment - Code comment typos # Testing Here is a published release which you can post in the Releases section after merging the PR if you'd like: [ntfy.sh Release.zip](https://github.com/lucas-bortoli/ntfysh-windows/files/12850290/ntfy.sh.Release.zip)
alexhorner commented 2023-10-22 05:56:41 -04:00 (Migrated from github.com)
Copy Link

ping @lucas-bortoli

ping @lucas-bortoli
alexhorner commented 2023-12-08 18:53:25 -05:00 (Migrated from github.com)
Copy Link

Bump @lucas-bortoli

Bump @lucas-bortoli
lucas-bortoli commented 2023-12-28 10:14:26 -05:00 (Migrated from github.com)
Copy Link

Hi! Sorry for the delay, I've been crazy busy these last weeks.

Hi! Sorry for the delay, I've been crazy busy these last weeks.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
minster586
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Smartcraft-Media-Tech/ntfysh-windows#11
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?