Smartcraft-Media-Tech/ntfysh-windows
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 4 Wiki Activity

Major overhaul #2

Merged
alexhorner merged 14 commits from master into master 2022-12-08 08:13:17 -05:00
Conversation 3 Commits 14 Files Changed 19
+1457 -854
alexhorner commented 2022-12-06 18:39:57 -05:00 (Migrated from github.com)
Copy Link
Copy Source

What I have done

  • Fixes #1 by adding support for custom servers, and authenticated topics
  • Complete rewrite of many parts, especially around better asynchronisation
  • Upgrade project to .NET Core 6.0-Windows (still a windows specific app because of WinForms though! Just better language support and more C# features)
  • Completely replace saved topics format to support custom servers and authenticated topics.
  • Built in converter which detects old topics.txt file and converts it automatically to topics.json
  • Some small bugfixes around existing features
  • Add support for websockets
  • Add proper connection failure handling with time delay backoff after first attempt
  • Redesigned the main form to better fit long topic and server names
  • Rename Form1 to MainForm

Testing

Here is a zipped production release of this PR so you don't have to compile it yourself if you don't want to:

ntfysh_client.zip

Screenshots

New main layout:
image

Multiple topics on different servers and using different connection methods (HTTP JSON/WebSocket):
image

New subscribe dialog:
image

Example connection failure error:
image

Example bad credentials error:
image

Example missing credentials error:
image

# What I have done - Fixes #1 by adding support for custom servers, and authenticated topics - Complete rewrite of many parts, especially around better asynchronisation - Upgrade project to .NET Core 6.0-Windows (still a windows specific app because of WinForms though! Just better language support and more C# features) - Completely replace saved topics format to support custom servers and authenticated topics. - Built in converter which detects old `topics.txt` file and converts it automatically to `topics.json` - Some small bugfixes around existing features - Add support for websockets - Add proper connection failure handling with time delay backoff after first attempt - Redesigned the main form to better fit long topic and server names - Rename Form1 to MainForm # Testing Here is a zipped production release of this PR so you don't have to compile it yourself if you don't want to: [ntfysh_client.zip](https://github.com/lucas-bortoli/ntfysh-windows/files/10180913/ntfysh_client.zip) # Screenshots New main layout: ![image](https://user-images.githubusercontent.com/33007665/206319958-a73eb8c2-6bcd-40bd-823a-e0121734ccec.png) --- Multiple topics on different servers and using different connection methods (HTTP JSON/WebSocket): ![image](https://user-images.githubusercontent.com/33007665/206320067-4f407e4f-116e-47a0-968b-981499af5417.png) --- New subscribe dialog: ![image](https://user-images.githubusercontent.com/33007665/206320089-53ea2220-f7bc-47c2-a7d0-89f295c1cb6c.png) --- Example connection failure error: ![image](https://user-images.githubusercontent.com/33007665/206320278-f1da5f06-1cbe-47bc-b88d-18d1e4dacf3f.png) --- Example bad credentials error: ![image](https://user-images.githubusercontent.com/33007665/206320475-a9546f95-eba7-4dfc-ab63-e6627e6d2d9f.png) --- Example missing credentials error: ![image](https://user-images.githubusercontent.com/33007665/206320572-2760e322-7af8-45e7-8d2d-e708fbcad7ed.png)
nwithan8 commented 2022-12-07 18:51:54 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Awesome work. If you want (shameless plug), might I recommend https://github.com/nwithan8/ntfy-dotnet?

Awesome work. If you want (shameless plug), might I recommend https://github.com/nwithan8/ntfy-dotnet?
alexhorner commented 2022-12-07 18:53:36 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Awesome work. If you want (shameless plug), might I recommend https://github.com/nwithan8/ntfy-dotnet?

Hey there! I'm aware of that, mainly didn't use it though because I wanted to keep this super lightweight and not dependent on third party libraries. Thanks for looking at the PR!

> Awesome work. If you want (shameless plug), might I recommend https://github.com/nwithan8/ntfy-dotnet? Hey there! I'm aware of that, mainly didn't use it though because I wanted to keep this super lightweight and not dependent on third party libraries. Thanks for looking at the PR!
👍 1
lucas-bortoli commented 2022-12-08 08:13:05 -05:00 (Migrated from github.com)
Copy Link
Copy Source

Hey there!
Nice work @alexhorner! I'm glad you picked this project up and improved it so much. I'm merging this ASAP.
Thanks for your contribution!

Hey there! Nice work @alexhorner! I'm glad you picked this project up and improved it so much. I'm merging this ASAP. Thanks for your contribution!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
minster586 (minster586)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Smartcraft-Media-Tech/ntfysh-windows#2