Update to 1.8.8, properly declare permissions in plugin.yml

src/com/lishid/openinv/commands/AnyChestPluginCommand.java

@@ -23,22 +23,18 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 
 import com.lishid.openinv.OpenInv;
-import com.lishid.openinv.Permissions;
 
 public class AnyChestPluginCommand implements CommandExecutor {
     public AnyChestPluginCommand(OpenInv plugin) {
 
     }
 
+    @Override
     public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
         if (!(sender instanceof Player)) {
             sender.sendMessage(ChatColor.RED + "You can't use this from the console.");
             return true;
         }
-        if (!OpenInv.hasPermission(sender, Permissions.PERM_ANYCHEST)) {
-            sender.sendMessage(ChatColor.RED + "You do not have permission to use anychest.");
-            return true;
-        }
 
         if (args.length > 0) {
             if (args[0].equalsIgnoreCase("check")) {

src/com/lishid/openinv/commands/OpenEnderPluginCommand.java

@@ -49,11 +49,6 @@ public class OpenEnderPluginCommand implements CommandExecutor {
             return true;
         }
 
-        if (!OpenInv.hasPermission(sender, Permissions.PERM_ENDERCHEST)) {
-            sender.sendMessage(ChatColor.RED + "You do not have permission to access player enderchest");
-            return true;
-        }
-
         if (args.length > 0 && args[0].equalsIgnoreCase("?")) {
             OpenInv.ShowHelp((Player) sender);
             return true;

src/com/lishid/openinv/commands/OpenInvPluginCommand.java

@@ -48,10 +48,6 @@ public class OpenInvPluginCommand implements CommandExecutor {
             sender.sendMessage(ChatColor.RED + "You can't use this from the console.");
             return true;
         }
-        if (!OpenInv.hasPermission(sender, Permissions.PERM_OPENINV)) {
-            sender.sendMessage(ChatColor.RED + "You do not have permission to access player inventories");
-            return true;
-        }
 
         if (args.length > 0 && args[0].equalsIgnoreCase("?")) {
             OpenInv.ShowHelp((Player) sender);

src/com/lishid/openinv/commands/SearchInvPluginCommand.java

@@ -24,22 +24,13 @@ import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 
-import com.lishid.openinv.OpenInv;
-import com.lishid.openinv.Permissions;
-
 public class SearchInvPluginCommand implements CommandExecutor {
     public SearchInvPluginCommand() {
 
     }
 
+    @Override
     public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
-        if (sender instanceof Player) {
-            if (!OpenInv.hasPermission(sender, Permissions.PERM_SEARCH)) {
-                sender.sendMessage(ChatColor.RED + "You do not have permission to access player inventories");
-                return true;
-            }
-        }
-
         String PlayerList = "";
 
         Material material = null;

src/com/lishid/openinv/commands/SilentChestPluginCommand.java

@@ -23,22 +23,18 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 
 import com.lishid.openinv.OpenInv;
-import com.lishid.openinv.Permissions;
 
 public class SilentChestPluginCommand implements CommandExecutor {
     public SilentChestPluginCommand(OpenInv plugin) {
 
     }
 
+    @Override
     public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
         if (!(sender instanceof Player)) {
             sender.sendMessage(ChatColor.RED + "You can't use this from the console.");
             return true;
         }
-        if (!OpenInv.hasPermission(sender, Permissions.PERM_SILENT)) {
-            sender.sendMessage(ChatColor.RED + "You do not have permission to use silent chest.");
-            return true;
-        }
 
         if (args.length > 0) {
             if (args[0].equalsIgnoreCase("check")) {

src/com/lishid/openinv/commands/ToggleOpenInvPluginCommand.java

@@ -24,19 +24,15 @@ import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 
 import com.lishid.openinv.OpenInv;
-import com.lishid.openinv.Permissions;
 
 public class ToggleOpenInvPluginCommand implements CommandExecutor {
 
+    @Override
     public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
         if (!(sender instanceof Player)) {
             sender.sendMessage(ChatColor.RED + "You can't use this from the console.");
             return true;
         }
-        if (!OpenInv.hasPermission(sender, Permissions.PERM_OPENINV)) {
-            sender.sendMessage(ChatColor.RED + "You do not have permission to access player inventories");
-            return true;
-        }
 
         Player player = (Player) sender;
         if (args.length > 0) {

src/com/lishid/openinv/internal/v1_8_R3/SpecialPlayerInventory.java

@@ -147,7 +147,7 @@ public class SpecialPlayerInventory extends PlayerInventory implements ISpecialP
                 return itemstack;
             }
             else {
-                itemstack = is[i].a(j);
+                itemstack = is[i].cloneAndSubtract(j);
                 if (is[i].count == 0) {
                     is[i] = null;
                 }

src/plugin.yml

@@ -8,31 +8,37 @@ commands:
   openinv:
     aliases: [oi, inv, open]
     description: Open a player's inventory
+    permission: OpenInv.openinv
     usage: |
            /<command> - Open last person's inventory
            /<command> <Player> - Open a player's inventory
   openender:
     aliases: [oe]
     description: Opens the enderchest of a player
+    permission: OpenInv.openender
     usage: |
            /<command> <Player> - Opens a player's enderchest
   searchinv:
     aliases: [si]
     description: Search and list players having a specific item
+    permission: OpenInv.search
     usage: |
            /<command> <Item> [MinAmount] - Item can be the Item ID or the CraftBukkit Item Name, MinAmount is the minimum amount to be considered.
   toggleopeninv:
     aliases: [toi, toggleoi, toggleinv]
     description: Toggle item openinv function
+    permission: OpenInv.openinv
     usage: |
            /<command> [Check] - Checks whether item openinv is enabled
   silentchest:
     aliases: [sc, silent]
     description: Toggle silent chest function, which hides the animation of a chest when opened or closed, and suppresses the sound.
+    permission: OpenInv.silent
     usage: |
            /<command> [Check] - Checks whether silent chest is enabled
   anychest:
     aliases: [ac]
     description: Toggle anychest function, which allows opening of blocked chests.
+    permission: OpenInv.anychest
     usage: |
            /<command> [Check] - Checks whether anychest is enabled