minster586/OpenInv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 36 Wiki Activity

Improve language manager (#116)

Browse Source 
* Clarify replacements internally to reduce the likelihood of messing up when including new ones
 * Fix missing keys not being written to disk for easy translation
 * Use a guessfile-like system where missing translation keys are inserted into a separate section for easy identification
 * Reduce verbosity of missing keys warning
This commit is contained in:
Adam
2022-12-20 15:54:30 -05:00
committed by GitHub
parent e39f092f14
commit 81eb60f628
10 changed files with 310 additions and 195 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugin/src/main/java/com/lishid/openinv/OpenInv.java
View File

@@ -28,9 +28,10 @@ import com.lishid.openinv.internal.ISpecialEnderChest;
import com.lishid.openinv.internal.ISpecialInventory;
import com.lishid.openinv.internal.ISpecialPlayerInventory;
import com.lishid.openinv.util.ConfigUpdater;
import com.lishid.openinv.util.LanguageManager;
import com.lishid.openinv.util.Permissions;
import com.lishid.openinv.util.StringMetric;
import com.lishid.openinv.util.lang.LanguageManager;
import com.lishid.openinv.util.lang.Replacement;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.Map;
@@ -463,7 +464,7 @@ public class OpenInv extends JavaPlugin implements IOpenInv {
public @Nullable String getLocalizedMessage(
@NotNull CommandSender sender,
@NotNull String key,
String @NotNull ... replacements) {
Replacement @NotNull ... replacements) {
return this.languageManager.getValue(key, getLocale(sender), replacements);
}
@@ -483,7 +484,7 @@ public class OpenInv extends JavaPlugin implements IOpenInv {
}
}
public void sendMessage(@NotNull CommandSender sender, @NotNull String key, String @NotNull... replacements) {
public void sendMessage(@NotNull CommandSender sender, @NotNull String key, Replacement @NotNull... replacements) {
String message = getLocalizedMessage(sender, key, replacements);
if (message != null && !message.isEmpty()) {