Allow using SilentChest to force loot generation #105

New Issue

Closed

opened 2019-06-01 03:02:28 -04:00 by ironik42 · 8 comments

ironik42 commented 2019-06-01 03:02:28 -04:00 (Migrated from github.com)

Copy Link

I get this error every time I try to open a newly discovered and naturally generated chest. Cannot reproduce error in a vanilla world(no mods). Error occurs on latest release of Spigot [git-Spigot-01d0f04-b7fea42 (MC: 1.14.2)] and PaperMC [git-Paper-58 (MC: 1.14.2)]. The error is on screen only - nothing shows up in the log file. Adding a screenshot to show. *edit: removing the OpenInv.jar file fixes the issue but I would prefer to not have to delete it :) .

I get this error every time I try to open a newly discovered and naturally generated chest. Cannot reproduce error in a vanilla world(no mods). Error occurs on latest release of Spigot [git-Spigot-01d0f04-b7fea42 (MC: 1.14.2)] and PaperMC [git-Paper-58 (MC: 1.14.2)]. The error is on screen only - nothing shows up in the log file. Adding a screenshot to show. *edit: removing the OpenInv.jar file fixes the issue but I would prefer to not have to delete it :) . 

RoboMWM commented 2019-06-01 09:18:25 -04:00 (Migrated from github.com)

Copy Link

Well that makes sense. The loot generates when a player opens it. When "opening" silently you're bypassing this mechanism. Just exit silentchest mode if you wish for the chest to generate loot.

Well that makes sense. The loot generates when a player opens it. When "opening" silently you're bypassing this mechanism. Just exit silentchest mode if you wish for the chest to generate loot.

Jikoo commented 2019-06-01 15:46:31 -04:00 (Migrated from github.com)

Copy Link

As Robo said, stop using SilentContainer to generate loot.

As Robo said, stop using SilentContainer to generate loot.

ironik42 commented 2019-06-01 16:30:35 -04:00 (Migrated from github.com)

Copy Link

This never happened before 1.14.x. I used silenchest all through 1.12 and 1.13 and never had an issue using silentchest on unlooted chests. Your fix is more of a band-aid than a solution.

This never happened before 1.14.x. I used silenchest all through 1.12 and 1.13 and never had an issue using silentchest on unlooted chests. Your fix is more of a band-aid than a solution.

Jikoo commented 2019-06-01 16:52:53 -04:00 (Migrated from github.com)

Copy Link

What? There's no config change to make. Turn off SilentContainer for yourself in game via command. This has been a thing since we swapped to using spectate after the issues due to tile entity changes between Spigot and Paper.

What? There's no config change to make. Turn off SilentContainer for yourself in game via command. This has been a thing since we swapped to using spectate after the issues due to tile entity changes between Spigot and Paper.

Jikoo commented 2019-06-01 17:01:55 -04:00 (Migrated from github.com)

Copy Link

It's possible to force loot generation, so I'll add this as a feature, but it's definitely not the intended usage of OpenInv. SilentContainer is for checking up on existing stuff in conjunction with vanish plugins and the like, not for having constantly enabled while exploring.

It's possible to force loot generation, so I'll add this as a feature, but it's definitely not the intended usage of OpenInv. SilentContainer is for checking up on existing stuff in conjunction with vanish plugins and the like, not for having constantly enabled while exploring.

RoboMWM commented 2019-06-02 11:28:39 -04:00 (Migrated from github.com)

Copy Link

If anything I prefer it to not generate loot, so I assume this would come as another config option.

If anything I prefer it to not generate loot, so I assume this would come as another config option.

Jikoo commented 2019-06-02 13:19:20 -04:00 (Migrated from github.com)

Copy Link

I agree, honestly. I think a better approach to this "problem" is to take a leaf out of GP's book in encouraging responsible admin behavior and not have SilentContainer/AnyContainer persist across logins.

I agree, honestly. I think a better approach to this "problem" is to take a leaf out of GP's book in encouraging responsible admin behavior and not have SilentContainer/AnyContainer persist across logins.

Jikoo commented 2019-07-19 18:23:22 -04:00 (Migrated from github.com)

Copy Link

After some thought, leaving silentcontainer on constantly is not the intended purpose of the plugin, and I will not be adding loot generation. I have included a more clear error message in 3faf41ef. I will eventually likely make silentcontainer status not persist across sessions to encourage responsible admin behavior.

After some thought, leaving silentcontainer on constantly is not the intended purpose of the plugin, and I will not be adding loot generation. I have included a more clear error message in 3faf41ef. I will eventually likely make silentcontainer status not persist across sessions to encourage responsible admin behavior.

👍 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

feature/cursorcrafting

uuid-rework

4.1.8

4.1.7

4.1.6

4.1.5

4.1.4

4.1.3

4.1.2

4.1.1

4.1.0

4.0.8

4.0.7

4.0.6

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

3.3.7

3.3.6

3.3.5

3.3.4

3.3.4-A1

3.3.3

3.3.2

3.3.1

3.3.0

3.2.1

3.2.0

3.1.2

3.1.1

3.1.0

3.0.6

3.0.5

3.0.4

3.0.3

3.0.2

3.0.1

3.0.0

2.5.3

2.5.3-alpha-1

2.5.2

2.5.1

2.5.0

2.4.9

2.4.8

2.4.7

2.4.5

2.4.4

2.4.3

2.4.2

2.4.1

2.4.0

2.3.0

2.2.10

2.2.9

2.2.8

2.2.7

2.2.6

2.2.5

Labels

Clear labels

Bug

Cannot Reproduce

Enhancement

Fixed

Invalid

Low Priority

Need More Information

Pending

Question

No Label

Enhancement

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

minster586

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#105

No description provided.