minster586/OpenInv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 36 Wiki Activity

Console error at start #111

New Issue
Closed
opened 2019-08-16 13:17:35 -04:00 by AuracleTech · 6 comments
AuracleTech commented 2019-08-16 13:17:35 -04:00 (Migrated from github.com)
Copy Link

13:16:33 [WARNING] Plugin OpenInv v4.0.3 does not specify an api-version.

Easy to fix

13:16:33 [WARNING] Plugin OpenInv v4.0.3 does not specify an api-version. Easy to fix
Jikoo commented 2019-08-16 15:10:14 -04:00 (Migrated from github.com)
Copy Link

OpenInv supports 1.8, 1.13, and 1.14 currently. Spigot does not allow specifying older API versions, and will not load plugins which do specify them.

OpenInv supports 1.8, 1.13, and 1.14 currently. Spigot does not allow specifying older API versions, and will not load plugins which do specify them.
AuracleTech commented 2019-08-16 15:11:40 -04:00 (Migrated from github.com)
Copy Link

Then add api-version 1.8 so it knows to get the 1.8 API at minimum
Just to remove warning message

Then add api-version 1.8 so it knows to get the 1.8 API at minimum Just to remove warning message
👎 1
AuracleTech commented 2019-08-16 15:12:55 -04:00 (Migrated from github.com)
Copy Link

Oh ok Just understood your message, welp.... rip spigot, pretty sure there s a way tho

Oh ok Just understood your message, welp.... rip spigot, pretty sure there s a way tho
Jikoo commented 2019-08-16 17:19:33 -04:00 (Migrated from github.com)
Copy Link

Yeah, the only way is to specify api-version 1.13 or higher. Technically that would probably be fine, but since a) it's not really a problem and b) it's not actually true - the plugin is built against 1.8.8, I don't really want to include it.

I suppose it's worth reconsidering. This isn't an isolated request, it's a duplicate of #102. Would appreciate community feedback.

Yeah, the only way is to specify api-version 1.13 or higher. Technically that would probably be fine, but since a) it's not really a problem and b) it's not actually true - the plugin is [built against 1.8.8](https://github.com/lishid/OpenInv/blob/master/plugin/pom.xml#L39), I don't really want to include it. I suppose it's worth reconsidering. This isn't an isolated request, it's a duplicate of #102. Would appreciate community feedback.
Jikoo commented 2019-08-16 17:25:46 -04:00 (Migrated from github.com)
Copy Link

Actually, after more thought, I am likely to include api-version 1.13. The last time it came up I was opposed to it, but OpenInv's nature is that it is somewhat version-specific and volatile.
There is likely (very slight) additional unnecessary processing associated with OpenInv for legacy support it doesn't actually require. In addition, not including the API version would cause it to be a bit more annoying to do pretty printing for things like #35 if I ever get around to it.

Actually, after more thought, I am likely to include api-version 1.13. The last time it came up I was opposed to it, but OpenInv's nature is that it is somewhat version-specific and volatile. There is likely (very slight) additional unnecessary processing associated with OpenInv for legacy support it doesn't actually require. In addition, not including the API version would cause it to be a bit more annoying to do pretty printing for things like #35 if I ever get around to it.
AuracleTech commented 2019-08-16 17:37:54 -04:00 (Migrated from github.com)
Copy Link

Would be logic, cause api-version start from 1.13 so just adding the lowest api-version supported would fix the warning I think

Would be logic, cause api-version start from 1.13 so just adding the lowest api-version supported would fix the warning I think
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Bug
Cannot Reproduce
Enhancement
Fixed
Invalid
Low Priority
Need More Information
Pending
Question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
minster586
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/OpenInv#111
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?