minster586/OpenInv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 36 Wiki Activity

Add support for InvUnload #146

Merged
mfnalex merged 2 commits from master into master 2020-07-15 22:38:38 -04:00
Conversation 1 Commits 2 Files Changed 1 +6
mfnalex commented 2020-07-15 22:01:24 -04:00 (Migrated from github.com)
Copy Link

This will check if the PlayerInteractEvent is an instance of InvUnload's custom event extending the PlayerInteractEvent. If yes, the listener immediately exists, because it doesn't have to do anything.

This is checked by using Event#getClass#getName, so that no dependencies need to be added. It has no downsides at all, so it would be nice if you could consider merging this PR.

This will not cancel 3rd party plugins' events that extend PlayerInteractEvent.

This fixes #144

~~This will check if the PlayerInteractEvent is an instance of InvUnload's custom event extending the PlayerInteractEvent. If yes, the listener immediately exists, because it doesn't have to do anything.~~ ~~This is checked by using Event#getClass#getName, so that no dependencies need to be added. It has no downsides at all, so it would be nice if you could consider merging this PR.~~ This will not cancel 3rd party plugins' events that extend PlayerInteractEvent. This fixes #144
Jikoo commented 2020-07-15 22:37:47 -04:00 (Migrated from github.com)
Copy Link

Looks good, thanks!

Looks good, thanks!
🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Cannot Reproduce
Enhancement
Fixed
Invalid
Low Priority
Need More Information
Pending
Question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
minster586
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/OpenInv#146
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?