OpenInv keeps containers open #176

New Issue

Closed

opened 2021-02-08 13:59:31 -05:00 by leasoncre · 6 comments

leasoncre commented 2021-02-08 13:59:31 -05:00 (Migrated from github.com)

Copy Link

Paper 1.16.5-457
if ii open a container when not in vanish, the container stays visually open for any client that has been in the area when it was opened by an admin (this includes shulker boxes that increase their hitbox, and stay open)
only fix is to relog/re-place container

tested on shulker box, chest, and large_chest.
when openinv is unloaded on test server, new chests/unopened-chests don't stay open.

Paper 1.16.5-457 if ii open a container when not in vanish, the container stays visually open for any client that has been in the area when it was opened by an admin (this includes shulker boxes that increase their hitbox, and stay open) only fix is to relog/re-place container tested on shulker box, chest, and large_chest. when openinv is unloaded on test server, new chests/unopened-chests don't stay open.

Jikoo commented 2021-02-08 14:04:58 -05:00 (Migrated from github.com)

Copy Link

Sounds like an incompatibility with your vanish plugin. Please reproduce using only OpenInv.

Sounds like an incompatibility with your vanish plugin. Please reproduce using only OpenInv.

Jikoo commented 2021-02-08 14:15:12 -05:00 (Migrated from github.com)

Copy Link

I'm gonna write up a boilerplate explanation as to why that's probably happening here because this is the second of these issues in 2 days.

The reason you're likely seeing containers "freeze open" is that you are running a vanish plugin that attempts to implement its own SilentContainer functionality. Unfortunately, most vanish plugins cancel packets and cause Minecraft's internals to become confused. Because the internals are in the wrong state or the packets were intercepted, the close packets do not get sent to the client.
OpenInv, instead of messing around with packets and producing invalid server states, forces the container to treat the user as a spectator. This has the same effect - trapped chests don't trigger, sounds and animations don't play - while preventing the server from getting confused about what packets should be sent when.

If your vanish plugin has the capability, have it disable OpenInv's SilentContainer functionality while enabled.

I'm gonna write up a boilerplate explanation as to why that's probably happening here because this is the second of these issues in 2 days. The reason you're likely seeing containers "freeze open" is that you are running a vanish plugin that attempts to implement its own SilentContainer functionality. Unfortunately, most vanish plugins cancel packets and cause Minecraft's internals to become confused. Because the internals are in the wrong state or the packets were intercepted, the close packets do not get sent to the client. OpenInv, instead of messing around with packets and producing invalid server states, forces the container to treat the user as a spectator. This has the same effect - trapped chests don't trigger, sounds and animations don't play - while preventing the server from getting confused about what packets should be sent when. If your vanish plugin has the capability, have it disable OpenInv's SilentContainer functionality while enabled.

leasoncre commented 2021-02-08 14:21:37 -05:00 (Migrated from github.com)

Copy Link

i use SuperVanish, which also states it uses the spectator mode to open chests....
BUT at no point was i in vanish, so it shouldn't be related?

i use SuperVanish, which also states it uses the spectator mode to open chests.... BUT at no point was i in vanish, so it shouldn't be related?

Jikoo commented 2021-02-08 14:23:09 -05:00 (Migrated from github.com)

Copy Link

Please reproduce using only OpenInv.

> Please reproduce using only OpenInv.

leasoncre commented 2021-02-08 14:33:47 -05:00 (Migrated from github.com)

Copy Link

for some reason i had openinv.silent FALSE set on my player in LuckPerms, WITH it enabled.... must have done derped ages ago and never looked into it.
+Removing that node and turning it off fixed the issue
thank you
-fixed/resolved

for some reason i had `openinv.silent FALSE` set on my player in LuckPerms, WITH it enabled.... must have done derped ages ago and never looked into it. +Removing that node and turning it off fixed the issue thank you -fixed/resolved

leasoncre commented 2021-02-08 14:40:23 -05:00 (Migrated from github.com)

Copy Link

ONE thing to note with this is that after changing the silentchest setting to off... .containers already stuck open do not fix themselves until relogging (not even by re-opening them, which i would have expected to work)

ONE thing to note with this is that after changing the silentchest setting to off... .containers already stuck open do not fix themselves until relogging (not even by re-opening them, which i would have expected to work)

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

feature/cursorcrafting

uuid-rework

4.1.8

4.1.7

4.1.6

4.1.5

4.1.4

4.1.3

4.1.2

4.1.1

4.1.0

4.0.8

4.0.7

4.0.6

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

3.3.7

3.3.6

3.3.5

3.3.4

3.3.4-A1

3.3.3

3.3.2

3.3.1

3.3.0

3.2.1

3.2.0

3.1.2

3.1.1

3.1.0

3.0.6

3.0.5

3.0.4

3.0.3

3.0.2

3.0.1

3.0.0

2.5.3

2.5.3-alpha-1

2.5.2

2.5.1

2.5.0

2.4.9

2.4.8

2.4.7

2.4.5

2.4.4

2.4.3

2.4.2

2.4.1

2.4.0

2.3.0

2.2.10

2.2.9

2.2.8

2.2.7

2.2.6

2.2.5

Labels

Clear labels

Bug

Cannot Reproduce

Enhancement

Fixed

Invalid

Low Priority

Need More Information

Pending

Question

No Label

Invalid

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

minster586

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#176

No description provided.