minster586/OpenInv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 36 Wiki Activity

Fix & improve UUID retrieval #29

Merged
ShadowRanger merged 1 commits from master into master 2015-07-10 18:55:17 -04:00
Conversation 3 Commits 1 Files Changed 1 +21 -20
ShadowRanger commented 2015-07-10 05:51:27 -04:00 (Migrated from github.com)
Copy Link

lishid I was really confused to what you meant by the custom method of checking to see if we're on the main thread so I wasn't able to add it here and instead used the method that Bukkit provides. I understood what you meant but I just wasn't sure how you wanted me to implement it. By that I mean UUIDUtils.getUUIDOf is only called in a couple of the commands and the config updater and I wasn't sure under what circumstances the method would be called with the boolean as true or false. If you'd rather me do it I'd be happy to but if possible please try and explain how you meant it because I'm a little bit confused, sorry.

So just let me know if you're happy with this pull request or would like me to make any changes to it.

lishid I was really confused to what you meant by the custom method of checking to see if we're on the main thread so I wasn't able to add it here and instead used the method that Bukkit provides. I understood what you meant but I just wasn't sure how you wanted me to implement it. By that I mean UUIDUtils.getUUIDOf is only called in a couple of the commands and the config updater and I wasn't sure under what circumstances the method would be called with the boolean as true or false. If you'd rather me do it I'd be happy to but if possible please try and explain how you meant it because I'm a little bit confused, sorry. So just let me know if you're happy with this pull request or would like me to make any changes to it.
lishid commented 2015-07-10 18:55:19 -04:00 (Migrated from github.com)
Copy Link

Looks good for now, I'll make some adjustments later on maybe.

Looks good for now, I'll make some adjustments later on maybe.
ShadowRanger commented 2015-07-12 04:11:52 -04:00 (Migrated from github.com)
Copy Link

Would you like me to compile the code and update the plugin on BukkitDev?

Would you like me to compile the code and update the plugin on BukkitDev?
lishid commented 2015-07-13 14:48:47 -04:00 (Migrated from github.com)
Copy Link

Would be cool if you can do that, thanks! (Also sorry, I've been out without internet for two days)

Would be cool if you can do that, thanks! (Also sorry, I've been out without internet for two days)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Cannot Reproduce
Enhancement
Fixed
Invalid
Low Priority
Need More Information
Pending
Question
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
minster586
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/OpenInv#29
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?