Improper caching causing dupes for offline players #49

New Issue

Closed

opened 2016-07-09 11:14:17 -04:00 by Jikoo · 2 comments

Jikoo commented 2016-07-09 11:14:17 -04:00 (Migrated from github.com)

Copy Link

Copy Source

Jikoo#10

This is a rare case. The Player loaded by the PlayerDataManager is a new object for SpecialEnderChest and SpecialPlayerInventory.

To replicate dupe/overwrite issues:

1. Open an offline player's inventory to cache it
2. Open the offline player's ender chest to cache it
3. Edit both inventories
4. Restart server to clear cached inventories (cached inventories only clear when players go offline - some retention policy would be good, the current state is bad)
5. Reopen inventories to see whichever was closed first reverted to previous state

The root cause is that the ISpecialEnderChest and ISpecialPlayerInventory implementations do not use the same Player object. That means that whichever saves last causes the other inventory to revert to its previous state, provided the actual Player does not log in before the server is restarted.

Jikoo#10 > This is a rare case. The Player loaded by the PlayerDataManager is a new object for SpecialEnderChest and SpecialPlayerInventory. > > To replicate dupe/overwrite issues: > 1. Open an offline player's inventory to cache it > 2. Open the offline player's ender chest to cache it > 3. Edit both inventories > 4. Restart server to clear cached inventories (cached inventories only clear when players go offline - some retention policy would be good, the current state is bad) > 5. Reopen inventories to see whichever was closed first reverted to previous state The root cause is that the ISpecialEnderChest and ISpecialPlayerInventory implementations do not use the same Player object. That means that whichever saves last causes the other inventory to revert to its previous state, provided the actual Player does not log in before the server is restarted.

Jikoo commented 2016-07-10 08:05:30 -04:00 (Migrated from github.com)

Copy Link

Copy Source

For fixes, Phoenix616 has an elegantly simple fix in 0665dec.
My fix (23bda96) also works, but uses a much more beefy system mainly aimed around not caching players who haven't logged in forever.

For fixes, Phoenix616 has an elegantly simple fix in 0665dec. My fix (23bda96) also works, but uses a much more beefy system mainly aimed around not caching players who haven't logged in forever.

Jikoo commented 2016-11-26 00:57:43 -05:00 (Migrated from github.com)

Copy Link

Copy Source

Fixed in 3.0.0

Fixed in 3.0.0

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

feature/cursorcrafting

uuid-rework

4.1.8

4.1.7

4.1.6

4.1.5

4.1.4

4.1.3

4.1.2

4.1.1

4.1.0

4.0.8

4.0.7

4.0.6

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

3.3.7

3.3.6

3.3.5

3.3.4

3.3.4-A1

3.3.3

3.3.2

3.3.1

3.3.0

3.2.1

3.2.0

3.1.2

3.1.1

3.1.0

3.0.6

3.0.5

3.0.4

3.0.3

3.0.2

3.0.1

3.0.0

2.5.3

2.5.3-alpha-1

2.5.2

2.5.1

2.5.0

2.4.9

2.4.8

2.4.7

2.4.5

2.4.4

2.4.3

2.4.2

2.4.1

2.4.0

2.3.0

2.2.10

2.2.9

2.2.8

2.2.7

2.2.6

2.2.5

Labels

Clear labels

Bug

Cannot Reproduce

Enhancement

Fixed

Invalid

Low Priority

Need More Information

Pending

Question

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

minster586 (minster586)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#49