OP user ignores permission nodes #85

Closed
opened 2018-05-25 18:05:37 -04:00 by k0nker · 7 comments
k0nker commented 2018-05-25 18:05:37 -04:00 (Migrated from github.com)

I have created a permission group that removes things from OP, it works since plugins just search for the permission to give access to a command. However, this plugin is the only one that is ignoring the removal of a node, specifically openinv.override.

Essentials, CorePortect, WorldGuard, WorldEdit, etc, all listen to the perm group that gives their perms a false flag and denies the ability to use their commands to those with OP, but OpenInv is letting anyone with OP override the .exempt node on players.

As for why I did this, I wanted to give my staff members the ability to utilize command blocks, but nothing extra that op gives (like *.* permissions). Is there a chance you can add in the ability to not default the permissions to OP users? Or if there's an ISOP() boolean in the permission check, maybe have a way to turn it off in the config?

I have created a permission group that removes things from OP, it works since plugins just search for the permission to give access to a command. However, this plugin is the only one that is ignoring the removal of a node, specifically openinv.override. Essentials, CorePortect, WorldGuard, WorldEdit, etc, all listen to the perm group that gives their perms a false flag and denies the ability to use their commands to those with OP, but OpenInv is letting anyone with OP override the .exempt node on players. As for why I did this, I wanted to give my staff members the ability to utilize command blocks, but nothing extra that op gives (like \*.* permissions). Is there a chance you can add in the ability to not default the permissions to OP users? Or if there's an ISOP() boolean in the permission check, maybe have a way to turn it off in the config?
RoboMWM commented 2018-05-25 19:08:26 -04:00 (Migrated from github.com)

Set negation nodes if you don't want your ops to actually be ops...

Set negation nodes if you don't want your ops to actually be ops...
k0nker commented 2018-05-25 19:25:38 -04:00 (Migrated from github.com)

@RoboMWM I already did that. The problem I am having is that OpenInv doesn't recognize that the permission openinv.override is set to false when the user is OP'd. Not only that node, but everything under openinv turns on when OP'd, even if the nodes are each set to false.

@RoboMWM I already did that. The problem I am having is that OpenInv doesn't recognize that the permission `openinv.override` is set to false when the user is OP'd. Not only that node, but everything under openinv turns on when OP'd, even if the nodes are each set to false.
Jikoo commented 2018-05-26 04:54:38 -04:00 (Migrated from github.com)

Guess we'll have to actually check what each PermissionAttachment sets values to rather than using a basic permissions check.

As a bandaid, you can negate OpenInv.*

Guess we'll have to actually check what each PermissionAttachment sets values to rather than using a basic permissions check. As a bandaid, you can negate `OpenInv.*`
k0nker commented 2018-05-26 04:57:18 -04:00 (Migrated from github.com)

I already attempted to just negate openinv.* in the permissions and it also did not work.

To be clear, I have attempted to set each individual permission node as well as the wildcard, and any variation I could think of, to false. None of it accomplished the goal.

I already attempted to just negate openinv.* in the permissions and it also did not work. To be clear, I have attempted to set each individual permission node as well as the wildcard, and any variation I could think of, to false. None of it accomplished the goal.
Jikoo commented 2018-05-26 05:00:13 -04:00 (Migrated from github.com)

Oops, you'll also need to negate *. I really hate wildcards.

Oops, you'll also need to negate `*`. I really hate wildcards.
Jikoo commented 2018-05-26 07:00:15 -04:00 (Migrated from github.com)

Please try OpenInv.zip

Please try [OpenInv.zip](https://github.com/lishid/OpenInv/files/2041557/OpenInv.zip)
Jikoo commented 2018-07-29 10:11:13 -04:00 (Migrated from github.com)

3.3.4 contains this fix. I'm assuming it works as intended due to the lack of response.

[3.3.4](https://github.com/lishid/OpenInv/releases/tag/3.3.4) contains this fix. I'm assuming it works as intended due to the lack of response.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/OpenInv#85
No description provided.