PlayerInteractEvent 1.13.2 #94

New Issue

@RoboMWM Because the stacktrace is engouht: Caused by: java.lang.NoSuchMethodError: net.minecraft.server.v1_13_R2.VoxelShape.a()Lnet/minecraft/server/v1_13_R2/AxisAlignedBB;

Something changed (and removed) from latest builds of Spigot/Paper

@RoboMWM Because the stacktrace is engouht: `Caused by: java.lang.NoSuchMethodError: net.minecraft.server.v1_13_R2.VoxelShape.a()Lnet/minecraft/server/v1_13_R2/AxisAlignedBB;` Something changed (and removed) from latest builds of Spigot/Paper

RoboMWM commented

2019-01-06 23:11:17 -05:00

(Migrated from github.com)

idk how the stacktrace is enough, yes a method was removed but still doesn't dictate what circumstances cause that to be called.

Thanks seema84.

idk how the stacktrace is enough, yes a method was removed but still doesn't dictate what circumstances cause that to be called. Thanks seema84.

RoboMWM commented

2019-01-07 13:04:36 -05:00

(Migrated from github.com)

Oh, I think I know why - md_5 changed mappings and didn't bother to bump the NMS version to "prevent breaking plugins"

Except he broke many significant NMS plugins like this, holographicdisplays, and some others people complained about afaik...

Oh, I think I know why - md_5 changed mappings and didn't bother to bump the NMS version to "prevent breaking plugins" Except he broke many significant NMS plugins like this, holographicdisplays, and some others people complained about afaik...

👍 2

Jikoo commented

2019-01-08 08:31:19 -05:00

(Migrated from github.com)

Hey guys, sorry I haven't gotten to this yet (or replied) - Robo is correct, there was a NMS mappings update without a NMS revision change.

My PC is currently broken, GPU is fried. I expect to be able to make some sort of inroads on the various issues that have cropped up in the past month or so by this weekend, but I'm out of commission for at least a couple more days.

Hey guys, sorry I haven't gotten to this yet (or replied) - Robo is correct, there was a NMS mappings update without a NMS revision change. My PC is currently broken, GPU is fried. I expect to be able to make some sort of inroads on the various issues that have cropped up in the past month or so by this weekend, but I'm out of commission for at least a couple more days.

👍 4

i0xHeX commented

2019-01-09 08:56:45 -05:00

(Migrated from github.com)

VoxelShape#a()
now
VoxelShape#getBoundingBox()

`VoxelShape#a()` now `VoxelShape#getBoundingBox()`

Uhevela commented

2019-01-13 07:28:48 -05:00

(Migrated from github.com)

Same error!
git-Paper-499 (MC: 1.13.2) and OpenInv v3.3.6

Same error! git-Paper-499 (MC: 1.13.2) and OpenInv v3.3.6

i0xHeX commented

2019-01-13 11:57:14 -05:00

(Migrated from github.com)

Quick fix guys! May use it until official fix will come here.
OpenInv-3.3.6-p1.zip

Quick fix guys! May use it until official fix will come here. [OpenInv-3.3.6-p1.zip](https://github.com/lishid/OpenInv/files/2753278/OpenInv-3.3.6-p1.zip)

RoboMWM commented

2019-01-13 13:14:32 -05:00

(Migrated from github.com)

@i0xHeX mind linking source, or better yet making a PR?

👍 2

crashdemons commented

2019-01-14 00:43:51 -05:00

(Migrated from github.com)

In case there's no response, here's a diff between decompiles of 3.3.6 and 3.3.6-p1 which might highlight the edits done. I might have missed something because I only saw one class that appeared to have a newer timestamp.

6c8321a4f1
(don't pull this, it lacks comments and has some bad commits in history)

EDIT: there shouldn't be any licensing issues with using this as an indicator because it's derivative under GPL

~~In case there's no response, here's a diff between decompiles of 3.3.6 and 3.3.6-p1 which might highlight the edits done. I might have missed something because I only saw one class that appeared to have a newer timestamp.~~ ~~https://github.com/crashdemons/OpenInv/commit/6c8321a4f1ed60a790139b507c1a21791a447e2e (don't pull this, it lacks comments and has some bad commits in history)~~ EDIT: there shouldn't be any licensing issues with using this as an indicator because it's derivative under GPL

i0xHeX commented

2019-01-15 11:31:23 -05:00

(Migrated from github.com)

In case there's no response, here's a diff between decompiles of 3.3.6 and 3.3.6-p1 which might highlight the edits done. I might have missed something because I only saw one class that appeared to have a newer timestamp.

crashdemons@6c8321a
(don't pull this, it lacks comments and has some bad commits in history)

EDIT: there shouldn't be any licensing issues with using this as an indicator because it's derivative under GPL

The only change needed to source is
VoxelShapes.b().a()
to
VoxelShapes.b().getBoundingBox()

All other changes are defect after decompilation / compilation.
I'm have no time to clone / pull request / build from sources. I made fast patch for my server and posted for anyone wants quick fix.

> In case there's no response, here's a diff between decompiles of 3.3.6 and 3.3.6-p1 which might highlight the edits done. I might have missed something because I only saw one class that appeared to have a newer timestamp. > > [crashdemons@6c8321a](https://github.com/crashdemons/OpenInv/commit/6c8321a4f1ed60a790139b507c1a21791a447e2e) > (don't pull this, it lacks comments and has some bad commits in history) > > EDIT: there shouldn't be any licensing issues with using this as an indicator because it's derivative under GPL The only change needed to source is `VoxelShapes.b().a()` to `VoxelShapes.b().getBoundingBox()` All other changes are defect after decompilation / compilation. I'm have no time to clone / pull request / build from sources. I made fast patch for my server and posted for anyone wants quick fix.

👎 1

crashdemons commented

2019-01-15 12:08:52 -05:00

(Migrated from github.com)

that's kind of what I figured and that the renaming of some other things was immaterial, but I wanted to be sure to document everything.

I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be a on un-updated ones.

Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?)

that's kind of what I figured and that the renaming of some other things was immaterial, but I wanted to be sure to document everything. I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be `a` on un-updated ones. Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?)

i0xHeX commented

2019-01-15 16:20:38 -05:00

(Migrated from github.com)

I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be a on un-updated ones.

Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?)

I think everybody should use latest 1.13.x build if on 1.13 major version. Just drop support.

> I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be `a` on un-updated ones. > > Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?) I think everybody should use latest 1.13.x build if on 1.13 major version. Just drop support.

Jikoo commented

2019-01-15 18:56:11 -05:00

(Migrated from github.com)

I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be a on un-updated ones.

Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?)

It would break older versions of 1.13. Because md_5 elected not to bump nms version, without going back and rewriting lishid's loader and any relevant internal classes, it's not possible to make a separate version.

In happier news, I finally finished yet another stage of repair, so I've managed to retrieve my usual ~~horrible mess~~ workspace setup.

>I wonder though if that change will break older 1.13.1 servers (and even older 1.13.2 builds, but they could rebuild?) relying on the same "internal" since it would still be a on un-updated ones. > >Would a new internal be added for that case separately, or does it need to be checked with method reflection because of the version being the same? (Or should users just update the server instead?) It would break older versions of 1.13. Because md_5 elected not to bump nms version, without going back and rewriting lishid's loader and any relevant internal classes, it's not possible to make a separate version. In happier news, I finally finished yet another stage of repair, so I've managed to retrieve my usual ~~horrible mess~~ workspace setup.

Jikoo commented

2019-01-15 20:10:42 -05:00

(Migrated from github.com)

Okay, this should work: OpenInv.zip I cannot test, because apparently Minecraft does not support the sweet sweet Intel integrated graphics driver I'm currently rocking. Feedback appreciated before I just blindly push out a release.

Okay, this should work: [OpenInv.zip](https://github.com/lishid/OpenInv/files/2762142/OpenInv.zip) I cannot test, because apparently Minecraft does not support the sweet sweet Intel integrated graphics driver I'm currently rocking. Feedback appreciated before I just blindly push out a release.

👍 2

takatalvi commented

2019-01-18 12:04:12 -05:00

(Migrated from github.com)

@Jikoo this build seems to be working just fine! Thanks so much!

👍 1 🎉 1

Jikoo commented

2019-01-18 20:36:33 -05:00

(Migrated from github.com)

3.3.7

[3.3.7](https://github.com/lishid/OpenInv/releases/tag/3.3.7)

👍 2