minster586/RealTimeWeather
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 8 Wiki Activity

fixted bug where time was only ever set to sunrise or sunset #12

Merged
hunter232 merged 1 commits from main into main 2024-08-06 21:03:21 -04:00
Conversation 2 Commits 1 Files Changed 1
+6 -4
hunter232 commented 2024-08-02 12:17:35 -04:00 (Migrated from github.com)
Copy Link
Copy Source

calucation of daytime and night time fractions were being done using integer division resulting in either a 0 or 1.
-change currentMinutes type from int to double, so that floating point division would be used.
-pulled out day time and night time fractions into their own doubles for clarity.
-type cast return values of calculateWorldTime from double to long to maintain previous structure.

calucation of daytime and night time fractions were being done using integer division resulting in either a 0 or 1. -change currentMinutes type from int to double, so that floating point division would be used. -pulled out day time and night time fractions into their own doubles for clarity. -type cast return values of calculateWorldTime from double to long to maintain previous structure.
hunter232 commented 2024-08-02 12:26:11 -04:00 (Migrated from github.com)
Copy Link
Copy Source

should have included this in the first comment...
compiled? - yes
loaded in papermc? - yes
fixed issue? - tested at 11:00, sun was over head( a bit to the east) instead of at horizon.

should have included this in the first comment... compiled? - yes loaded in papermc? - yes fixed issue? - tested at 11:00, sun was over head( a bit to the east) instead of at horizon.
Jack1424 commented 2024-08-06 21:02:48 -04:00 (Migrated from github.com)
Copy Link
Copy Source

I tested this and it does seem to resolve #11. Thanks for the help!

I tested this and it does seem to resolve #11. Thanks for the help!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
minster586 (minster586)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/RealTimeWeather#12