minster586/RealTimeWeather
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 8 Wiki Activity

fix SunriseSunsetRequest to use right config values #18

Merged
Karotte128 merged 1 commits from main into main 2025-05-29 00:51:18 -04:00
Conversation 1 Commits 1 Files Changed 1
+1 -1
Karotte128 commented 2025-02-22 16:12:50 -05:00 (Migrated from github.com)
Copy Link
Copy Source

The SunriseSunsetRequestObject originally used config.getWeatherLatitude (and longitude). I changed this to use the right values (config.getSunriseSunsetLongitude ...).
This is important because if the weather setting are not set in config, the SunriseSunset request will fail with HTTP error 500.

The SunriseSunsetRequestObject originally used config.getWeatherLatitude (and longitude). I changed this to use the right values (config.getSunriseSunsetLongitude ...). This is important because if the weather setting are not set in config, the SunriseSunset request will fail with HTTP error 500.
Jack1424 commented 2025-05-29 00:51:26 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Thank you!

Thank you!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
minster586 (minster586)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/RealTimeWeather#18