Added and applied styles for private readonly fields, private fields to Extensions and Common folders.

- Some renamings and code cleanups
- Chained method calls, binary expressions and binary patterns will now break into newlines
- Type param constraints and base constructor calls will be on the new line

src/NadekoBot/Common/SmartText/SmartEmbedText.cs

@@ -15,14 +15,13 @@ public sealed record SmartEmbedText : SmartText
 
     public uint Color { get; set; } = 7458112;
 
-    public bool IsValid =>
-        !string.IsNullOrWhiteSpace(Title) ||
-        !string.IsNullOrWhiteSpace(Description) ||
-        !string.IsNullOrWhiteSpace(Url) ||
-        !string.IsNullOrWhiteSpace(Thumbnail) ||
-        !string.IsNullOrWhiteSpace(Image) ||
-        (Footer != null && (!string.IsNullOrWhiteSpace(Footer.Text) || !string.IsNullOrWhiteSpace(Footer.IconUrl))) ||
-        Fields is { Length: > 0 };
+    public bool IsValid
+        => !string.IsNullOrWhiteSpace(Title) || !string.IsNullOrWhiteSpace(Description) ||
+           !string.IsNullOrWhiteSpace(Url) || !string.IsNullOrWhiteSpace(Thumbnail) ||
+           !string.IsNullOrWhiteSpace(Image) ||
+           (Footer != null &&
+            (!string.IsNullOrWhiteSpace(Footer.Text) || !string.IsNullOrWhiteSpace(Footer.IconUrl))) ||
+           Fields is { Length: > 0 };
 
     public static SmartEmbedText FromEmbed(IEmbed eb, string plainText = null)
     {
@@ -34,42 +33,23 @@ public sealed record SmartEmbedText : SmartText
             Url = eb.Url,
             Thumbnail = eb.Thumbnail?.Url,
             Image = eb.Image?.Url,
-            Author = eb.Author is { } ea
-                ? new()
-                {
-                    Name = ea.Name,
-                    Url = ea.Url,
-                    IconUrl = ea.IconUrl
-                }
-                : null,
-            Footer = eb.Footer is { } ef
-                ? new()
-                {
-                    Text = ef.Text,
-                    IconUrl = ef.IconUrl
-                }
-                : null
+            Author = eb.Author is { } ea ? new() { Name = ea.Name, Url = ea.Url, IconUrl = ea.IconUrl } : null,
+            Footer = eb.Footer is { } ef ? new() { Text = ef.Text, IconUrl = ef.IconUrl } : null
         };
 
         if (eb.Fields.Length > 0)
-            set.Fields = eb
-                .Fields
-                .Select(field => new SmartTextEmbedField()
-                {
-                    Inline = field.Inline,
-                    Name = field.Name,
-                    Value = field.Value,
-                })
+            set.Fields = eb.Fields.Select(field
+                    => new SmartTextEmbedField() { Inline = field.Inline, Name = field.Name, Value = field.Value, }
+                )
                 .ToArray();
 
         set.Color = eb.Color?.RawValue ?? 0;
         return set;
     }
-        
+
     public EmbedBuilder GetEmbed()
     {
-        var embed = new EmbedBuilder()
-            .WithColor(Color);
+        var embed = new EmbedBuilder().WithColor(Color);
 
         if (!string.IsNullOrWhiteSpace(Title))
             embed.WithTitle(Title);
@@ -77,26 +57,31 @@ public sealed record SmartEmbedText : SmartText
         if (!string.IsNullOrWhiteSpace(Description))
             embed.WithDescription(Description);
 
-        if (Url != null && Uri.IsWellFormedUriString(Url, UriKind.Absolute))
+        if (Url != null &&
+            Uri.IsWellFormedUriString(Url, UriKind.Absolute))
             embed.WithUrl(Url);
 
         if (Footer != null)
         {
             embed.WithFooter(efb =>
-            {
-                efb.WithText(Footer.Text);
-                if (Uri.IsWellFormedUriString(Footer.IconUrl, UriKind.Absolute))
-                    efb.WithIconUrl(Footer.IconUrl);
-            });
+                {
+                    efb.WithText(Footer.Text);
+                    if (Uri.IsWellFormedUriString(Footer.IconUrl, UriKind.Absolute))
+                        efb.WithIconUrl(Footer.IconUrl);
+                }
+            );
         }
 
-        if (Thumbnail != null && Uri.IsWellFormedUriString(Thumbnail, UriKind.Absolute))
+        if (Thumbnail != null &&
+            Uri.IsWellFormedUriString(Thumbnail, UriKind.Absolute))
             embed.WithThumbnailUrl(Thumbnail);
 
-        if (Image != null && Uri.IsWellFormedUriString(Image, UriKind.Absolute))
+        if (Image != null &&
+            Uri.IsWellFormedUriString(Image, UriKind.Absolute))
             embed.WithImageUrl(Image);
 
-        if (Author != null && !string.IsNullOrWhiteSpace(Author.Name))
+        if (Author != null &&
+            !string.IsNullOrWhiteSpace(Author.Name))
         {
             if (!Uri.IsWellFormedUriString(Author.IconUrl, UriKind.Absolute))
                 Author.IconUrl = null;
@@ -110,7 +95,8 @@ public sealed record SmartEmbedText : SmartText
         {
             foreach (var f in Fields)
             {
-                if (!string.IsNullOrWhiteSpace(f.Name) && !string.IsNullOrWhiteSpace(f.Value))
+                if (!string.IsNullOrWhiteSpace(f.Name) &&
+                    !string.IsNullOrWhiteSpace(f.Value))
                     embed.AddField(f.Name, f.Value, f.Inline);
             }
         }

src/NadekoBot/Common/SmartText/SmartText.cs

@@ -4,8 +4,11 @@ namespace NadekoBot;
 
 public abstract record SmartText
 {
-    public bool IsEmbed => this is SmartEmbedText;
-    public bool IsPlainText => this is SmartPlainText;
+    public bool IsEmbed
+        => this is SmartEmbedText;
+
+    public bool IsPlainText
+        => this is SmartPlainText;
 
     public static SmartText operator +(SmartText text, string input)
         => text switch
@@ -14,7 +17,7 @@ public abstract record SmartText
             SmartPlainText spt => new SmartPlainText(spt.Text + input),
             _ => throw new ArgumentOutOfRangeException(nameof(text))
         };
-        
+
     public static SmartText operator +(string input, SmartText text)
         => text switch
         {
@@ -22,10 +25,11 @@ public abstract record SmartText
             SmartPlainText spt => new SmartPlainText(input + spt.Text),
             _ => throw new ArgumentOutOfRangeException(nameof(text))
         };
-        
+
     public static SmartText CreateFrom(string input)
     {
-        if (string.IsNullOrWhiteSpace(input) || !input.TrimStart().StartsWith("{"))
+        if (string.IsNullOrWhiteSpace(input) ||
+            !input.TrimStart().StartsWith("{"))
         {
             return new SmartPlainText(input);
         }
@@ -34,6 +38,9 @@ public abstract record SmartText
         {
             var smartEmbedText = JsonConvert.DeserializeObject<SmartEmbedText>(input);
 
+            if (smartEmbedText is null)
+                throw new();
+            
             smartEmbedText.NormalizeFields();
 
             if (!smartEmbedText.IsValid)

src/NadekoBot/Common/SmartText/SmartTextEmbedAuthor.cs

@@ -5,8 +5,7 @@ namespace NadekoBot;
 public class SmartTextEmbedAuthor
 {
     public string Name { get; set; }
-    public string IconUrl { get; set; }
     [JsonProperty("icon_url")]
-    private string Icon_Url { set => IconUrl = value; }
+    public string IconUrl { get; set; }
     public string Url { get; set; }
 }

src/NadekoBot/Common/SmartText/SmartTextEmbedFooter.cs

@@ -2,10 +2,11 @@
 
 namespace NadekoBot;
 
+// todo test smarttextembedfooter and smarttextembedauthor
+
 public class SmartTextEmbedFooter
 {
     public string Text { get; set; }
-    public string IconUrl { get; set; }
     [JsonProperty("icon_url")]
-    private string Icon_Url { set => IconUrl = value; }
+    public string IconUrl { get; set; }
 }