Removed some unused classes, minor cleanup. Added rider anotations to stop some annoying code suggestions

src/NadekoBot/Common/Attributes/Description.cs

@@ -1,10 +0,0 @@
-namespace NadekoBot.Common.Attributes;
-
-[AttributeUsage(AttributeTargets.Method)]
-public sealed class DescriptionAttribute : SummaryAttribute
-{
-    // Localization.LoadCommand(memberName.ToLowerInvariant()).Desc
-    public DescriptionAttribute(string text = "") : base(text)
-    {
-    }
-}

src/NadekoBot/Common/Attributes/LeftoverAttribute.cs

@@ -1,8 +0,0 @@
-namespace Discord.Commands;
-
-public class LeftoverAttribute : RemainderAttribute
-{
-    public LeftoverAttribute()
-    {
-    }
-}

src/NadekoBot/Common/Attributes/Usage.cs

@@ -1,14 +0,0 @@
-namespace NadekoBot.Common.Attributes;
-
-[AttributeUsage(AttributeTargets.Method)]
-public sealed class UsageAttribute : RemarksAttribute
-{
-    // public static string GetUsage(string memberName)
-    // {
-    //     var usage = Localization.LoadCommand(memberName.ToLowerInvariant()).Usage;
-    //     return JsonConvert.SerializeObject(usage);
-    // }
-    public UsageAttribute(string text = "") : base(text)
-    {
-    }
-}

src/NadekoBot/Common/Collections/DisposableImutableList.cs

@@ -1,74 +0,0 @@
-using System.Collections;
-
-namespace NadekoBot.Common.Collections;
-
-public static class DisposableReadOnlyListExtensions
-{
-    public static IDisposableReadOnlyList<T> AsDisposable<T>(this IReadOnlyList<T> arr) where T : IDisposable
-        => new DisposableReadOnlyList<T>(arr);
-
-    public static IDisposableReadOnlyList<KeyValuePair<TKey, TValue>> AsDisposable<TKey, TValue>(this IReadOnlyList<KeyValuePair<TKey, TValue>> arr) where TValue : IDisposable
-        => new DisposableReadOnlyList<TKey, TValue>(arr);
-}
-
-public interface IDisposableReadOnlyList<T> : IReadOnlyList<T>, IDisposable
-{
-}
-
-public sealed class DisposableReadOnlyList<T> : IDisposableReadOnlyList<T>
-    where T : IDisposable
-{
-    private readonly IReadOnlyList<T> _arr;
-
-    public int Count => _arr.Count;
-
-    public T this[int index] => _arr[index];
-
-    public DisposableReadOnlyList(IReadOnlyList<T> arr)
-    {
-        this._arr = arr;
-    }
-
-    public IEnumerator<T> GetEnumerator()
-        => _arr.GetEnumerator();
-
-    IEnumerator IEnumerable.GetEnumerator()
-        => _arr.GetEnumerator();
-
-    public void Dispose()
-    {
-        foreach (var item in _arr)
-        {
-            item.Dispose();
-        }
-    }
-}
-
-public sealed class DisposableReadOnlyList<T, U> : IDisposableReadOnlyList<KeyValuePair<T, U>>
-    where U : IDisposable
-{
-    private readonly IReadOnlyList<KeyValuePair<T, U>> _arr;
-
-    public int Count => _arr.Count;
-
-    KeyValuePair<T, U> IReadOnlyList<KeyValuePair<T, U>>.this[int index] => _arr[index];
-
-    public DisposableReadOnlyList(IReadOnlyList<KeyValuePair<T, U>> arr)
-    {
-        this._arr = arr;
-    }
-
-    public IEnumerator<KeyValuePair<T, U>> GetEnumerator() =>
-        _arr.GetEnumerator();
-
-    IEnumerator IEnumerable.GetEnumerator() =>
-        _arr.GetEnumerator();
-
-    public void Dispose()
-    {
-        foreach (var item in _arr)
-        {
-            item.Value.Dispose();
-        }
-    }
-}

src/NadekoBot/Common/NadekoModule.cs

@@ -2,6 +2,9 @@
 
 namespace NadekoBot.Modules;
 
+[UsedImplicitly(ImplicitUseTargetFlags.Default
+                | ImplicitUseTargetFlags.WithInheritors
+                | ImplicitUseTargetFlags.WithMembers)]
 public abstract class NadekoModule : ModuleBase
 {
     protected CultureInfo _cultureInfo { get; set; }

src/NadekoBot/Db/NadekoContext.cs

@@ -46,7 +46,6 @@ public class NadekoContext : DbContext
     public DbSet<RotatingPlayingStatus> RotatingStatus { get; set; }
     public DbSet<BlacklistEntry> Blacklist { get; set; }
     public DbSet<AutoCommand> AutoCommands { get; set; } 
-        
     public DbSet<RewardedUser> RewardedUsers { get; set; }
     public DbSet<PlantedCurrency> PlantedCurrency { get; set; }
     public DbSet<BanTemplate> BanTemplates { get; set; }

src/NadekoBot/GlobalUsings.cs

@@ -16,5 +16,8 @@ global using Discord.WebSocket;
 global using GuildPerm = Discord.GuildPermission;
 global using ChannelPerm = Discord.ChannelPermission;
 global using BotPermAttribute = Discord.Commands.RequireBotPermissionAttribute;
+global using LeftoverAttribute = Discord.Commands.RemainderAttribute;
 
 global using System.Collections.Concurrent;
+
+global using JetBrains.Annotations;

src/NadekoBot/Modules/Administration/RoleCommands.cs

@@ -28,7 +28,6 @@ public partial class Administration
             if (input.Length % 2 != 0)
                 return;
 
-            var grp = 0;
             var results = input
                 .Chunk(input.Length / 2)
                 .Select(async x =>

src/NadekoBot/Modules/Searches/StreamNotificationCommands.cs

@@ -58,7 +58,7 @@ public partial class Searches
                     fs.Type));
         }
 
-        [NadekoCommand, Usage, Description, Aliases]
+        [NadekoCommand, Aliases]
         [RequireContext(ContextType.Guild)]
         [UserPerm(GuildPerm.Administrator)]
         public async Task StreamsClear()

src/NadekoBot/NadekoBot.csproj

@@ -54,6 +54,7 @@
     <PackageReference Include="YamlDotNet" Version="11.2.1" />
     <PackageReference Include="linq2db.EntityFrameworkCore" Version="6.6.1" />
     <PackageReference Include="Humanizer" Version="2.13.14" />
+    <PackageReference Include="JetBrains.Annotations" Version="2021.3.0" />
   </ItemGroup>
 
   <ItemGroup>