Updated CHANGELOG.md, upped version to 4.3.14

Replaced CN API

See merge request Kwoth/nadekobot!291

CHANGELOG.md

@@ -2,6 +2,16 @@
 
 Experimental changelog. Mostly based on [keepachangelog](https://keepachangelog.com/en/1.0.0/) except date format. a-c-f-r-o
 
+## [4.3.14] - 02.04.2023
+
+### Fixed
+
+- Fixed voice hearbeat issue
+- `.banktake` had ok/error responses flipped. No functional change
+- PermRole should deny messages in threads todo
+- Fixed chucknorris jokes
+- `.logserver` will now
+
 ## [4.3.13] - 20.02.2023
 
 ### Fixed

docs/config-guide.md

@@ -24,6 +24,10 @@ The list below is not complete. Use commands above to see up-to-date list for yo
 
 `trivia.min_win_req` - Restricts a user's ability to make a trivia game with a win requirement less than the set value.   
 `trivia.currency_reward` - Sets the amount of currency a user will win if they place first in a completed trivia game.  
+`hangman.currency_reward` - Sets the amount of currency a user will win if they win a game of hangman.  
+`chatbot` - Sets which chatbot API the bot should use, values: `gpt3`, `cleverbot`.  
+`gpt.model` - Sets which GPT-3 model the bot should use, values: `ada001`, `babbage001`, `curie001`, `davinci003`.  
+`gpt.max_tokens` - Sets the limit of tokens GPT-3 can use per call. Find out more about tokens [here](https://help.openai.com/en/articles/4936856-what-are-tokens-and-how-to-count-them).
 
 *more settings may be available in `data/games.yml` file*
 

docs/guides/linux-guide.md

@@ -20,7 +20,7 @@ It is recommended that you use **Ubuntu 20.04**, as there have been nearly no pr
 
 ##### Compatible operating systems:
 
-- Ubuntu: 16.04, 18.04, 20.04, 21.04, 21.10
+- Ubuntu: 16.04, 18.04, 20.04
 - Mint: 19, 20
 - Debian: 10, 11
 - CentOS: 7

src/NadekoBot/Common/TypeReaders/BotCommandTypeReader.cs

@@ -46,9 +46,7 @@ public sealed class CommandOrExprTypeReader : NadekoTypeReader<CommandOrExprInfo
 
     public override async ValueTask<TypeReaderResult<CommandOrExprInfo>> ReadAsync(ICommandContext ctx, string input)
     {
-        input = input.ToUpperInvariant();
+        if (_exprs.ExpressionExists(ctx.Guild?.Id, input))
-
-        if (_exprs.ExpressionExists(ctx.Guild?.Id, input) || _exprs.ExpressionExists(null, input))
             return TypeReaderResult.FromSuccess(new CommandOrExprInfo(input, CommandOrExprInfo.Type.Custom));
 
         var cmd = await new CommandTypeReader(_commandHandler, _cmds).ReadAsync(ctx, input);

src/NadekoBot/Db/Extensions/NadekoExpressionExtensions.cs

@@ -12,10 +12,4 @@ public static class NadekoExpressionExtensions
 
     public static IEnumerable<NadekoExpression> ForId(this DbSet<NadekoExpression> exprs, ulong id)
         => exprs.AsNoTracking().AsQueryable().Where(x => x.GuildId == id).ToList();
-
-    public static NadekoExpression GetByGuildIdAndInput(
-        this DbSet<NadekoExpression> exprs,
-        ulong? guildId,
-        string input)
-        => exprs.FirstOrDefault(x => x.GuildId == guildId && x.Trigger.ToUpper() == input);
 }

src/NadekoBot/Modules/Administration/Mute/MuteService.cs

@@ -19,6 +19,7 @@ public class MuteService : INService
 
     private static readonly OverwritePermissions _denyOverwrite = new(addReactions: PermValue.Deny,
         sendMessages: PermValue.Deny,
+        sendMessagesInThreads: PermValue.Deny,
         attachFiles: PermValue.Deny);
 
     public event Action<IGuildUser, IUser, MuteType, string> UserMuted = delegate { };

src/NadekoBot/Modules/Administration/ServerLog/ServerLogCommandService.cs

@@ -311,7 +311,8 @@ public sealed class LogCommandService : ILogCommandService, IReadyExecutor
             logSetting.UserLeftId = logSetting.UserBannedId = logSetting.UserUnbannedId = logSetting.UserUpdatedId =
                 logSetting.ChannelCreatedId = logSetting.ChannelDestroyedId = logSetting.ChannelUpdatedId =
                     logSetting.LogUserPresenceId = logSetting.LogVoicePresenceId = logSetting.UserMutedId =
-                        logSetting.LogVoicePresenceTTSId = value ? channelId : null;
+                        logSetting.LogVoicePresenceTTSId = logSetting.ThreadCreatedId = logSetting.ThreadDeletedId
+                            = logSetting.LogWarnsId = value ? channelId : null;
         await uow.SaveChangesAsync();
         GuildLogSettings.AddOrUpdate(guildId, _ => logSetting, (_, _) => logSetting);
     }

src/NadekoBot/Modules/Expressions/NadekoExpressionsService.cs

@@ -57,8 +57,8 @@ public sealed class NadekoExpressionsService : IExecOnMessage, IReadyExecutor
     // 1. expressions are almost never added (compared to how many times they are being looped through)
     // 2. only need write locks for this as we'll rebuild+replace the array on every edit
     // 3. there's never many of them (at most a thousand, usually < 100)
-    private NadekoExpression[] globalExpressions;
+    private NadekoExpression[] globalExpressions = Array.Empty<NadekoExpression>();
-    private ConcurrentDictionary<ulong, NadekoExpression[]> newguildExpressions;
+    private ConcurrentDictionary<ulong, NadekoExpression[]> newguildExpressions = new();
 
     private readonly DbService _db;
     private readonly DiscordSocketClient _client;
@@ -125,7 +125,7 @@ public sealed class NadekoExpressionsService : IExecOnMessage, IReadyExecutor
                     .ToArray())
             .ToConcurrent();
 
-        _disabledGlobalExpressionGuilds = new (await uow.GuildConfigs
+        _disabledGlobalExpressionGuilds = new(await uow.GuildConfigs
             .Where(x => x.DisableGlobalExpressions)
             .Select(x => x.GuildId)
             .ToListAsyncLinqToDB());
@@ -509,9 +509,25 @@ public sealed class NadekoExpressionsService : IExecOnMessage, IReadyExecutor
 
     public bool ExpressionExists(ulong? guildId, string input)
     {
-        using var uow = _db.GetDbContext();
+        input = input.ToLowerInvariant();
-        var expr = uow.Expressions.GetByGuildIdAndInput(guildId, input);
+
-        return expr is not null;
+        var gexprs = globalExpressions;
+        foreach (var t in gexprs)
+        {
+            if (t.Trigger == input)
+                return true;
+        }
+
+        if (guildId is ulong gid && newguildExpressions.TryGetValue(gid, out var guildExprs))
+        {
+            foreach (var t in guildExprs)
+            {
+                if (t.Trigger == input)
+                    return true;
+            }
+        }
+
+        return false;
     }
 
     public string ExportExpressions(ulong? guildId)

src/NadekoBot/Modules/Gambling/Bank/BankCommands.cs

@@ -77,14 +77,14 @@ public partial class Gambling
         {
             if (await _bank.TakeAsync(userId, amount))
             {
+                await ctx.OkAsync();
+                return;
+            }
+
             await ReplyErrorLocalizedAsync(strs.take_fail(N(amount),
                 _client.GetUser(userId)?.ToString()
                 ?? userId.ToString(),
                 CurrencySign));
-                return;
-            }
-            
-            await ctx.OkAsync();
         }
         
         private async Task BankAwardInternalAsync(long amount, ulong userId)

src/NadekoBot/Modules/Games/GamesConfig.cs

@@ -108,10 +108,10 @@ public sealed partial class GamesConfig : ICloneable<GamesConfig>
 public sealed partial class ChatGptConfig
 {
     [Comment(@"Which GPT-3 Model should bot use.
-'ada' - cheapest and fastest 
+'ada001' - cheapest and fastest 
-'babbage' - 2nd option
+'babbage001' - 2nd option
-'curie' - 3rd option
+'curie001' - 3rd option
-'davinci' - Most expensive, slowest")]
+'davinci003' - Most expensive, slowest")]
     public Gpt3Model Model { get; set; } = Gpt3Model.Ada001;
 
     [Comment(@"The maximum number of tokens to use per GPT-3 API call")]

src/NadekoBot/Modules/Searches/JokeCommands.cs

@@ -39,7 +39,7 @@ public partial class Searches
         [Cmd]
         public async Task MagicItem()
         {
-            if (!_service.WowJokes.Any())
+            if (!_service.MagicItems.Any())
             {
                 await ReplyErrorLocalizedAsync(strs.magicitems_not_loaded);
                 return;

src/NadekoBot/Modules/Searches/Searches.cs

@@ -199,7 +199,7 @@ public partial class Searches : NadekoModule<SearchesService>
         if (!await ValidateQuery(ffs))
             return;
 
-        var shortenedUrl = await _google.ShortenUrl($"https://lmgtfy.com/?q={Uri.EscapeDataString(ffs)}");
+        var shortenedUrl = await _google.ShortenUrl($"https://letmegooglethat.com/?q={Uri.EscapeDataString(ffs)}");
         await SendConfirmAsync($"<{shortenedUrl}>");
     }
 

src/NadekoBot/Modules/Searches/SearchesService.cs

@@ -296,8 +296,8 @@ public class SearchesService : INService
     public async Task<string> GetChuckNorrisJoke()
     {
         using var http = _httpFactory.CreateClient();
-        var response = await http.GetStringAsync(new Uri("http://api.icndb.com/jokes/random/"));
+        var response = await http.GetStringAsync(new Uri("https://api.chucknorris.io/jokes/random"));
-        return JObject.Parse(response)["value"]["joke"] + " 😆";
+        return JObject.Parse(response)["value"] + " 😆";
     }
 
     public async Task<MtgData> GetMtgCardAsync(string search)

src/NadekoBot/Services/Impl/StatsService.cs

@@ -7,7 +7,7 @@ namespace NadekoBot.Services;
 
 public sealed class StatsService : IStatsService, IReadyExecutor, INService
 {
-    public const string BOT_VERSION = "4.3.13";
+    public const string BOT_VERSION = "4.3.14";
 
     public string Author
         => "Kwoth#2452";

src/ayu/Ayu.Discord.Voice/VoiceGateway.cs

@@ -237,20 +237,25 @@ namespace Ayu.Discord.Voice
             _udpEp = new(IPAddress.Parse(ready.Ip), ready.Port);
 
             var ssrcBytes = BitConverter.GetBytes(Ssrc);
-            var ipDiscoveryData = new byte[70];
+            Array.Reverse(ssrcBytes);
-            Buffer.BlockCopy(ssrcBytes, 0, ipDiscoveryData, 0, ssrcBytes.Length);
+            var ipDiscoveryData = new byte[74];
+            Buffer.BlockCopy(ssrcBytes, 0, ipDiscoveryData, 4, ssrcBytes.Length);
+            ipDiscoveryData[0] = 0x00;
+            ipDiscoveryData[1] = 0x01;
+            ipDiscoveryData[2] = 0x00;
+            ipDiscoveryData[3] = 0x46;
             await _udpClient.SendAsync(ipDiscoveryData, ipDiscoveryData.Length, _udpEp);
             while (true)
             {
                 var buffer = _udpClient.Receive(ref _udpEp);
 
-                if (buffer.Length == 70)
+                if (buffer.Length == 74)
                 {
                     //Log.Information("Received IP discovery data.");
 
-                    var myIp = Encoding.UTF8.GetString(buffer, 4, buffer.Length - 8);
+                    var myIp = Encoding.UTF8.GetString(buffer, 8, buffer.Length - 10);
                     MyIp = myIp.TrimEnd('\0');
-                    MyPort = BitConverter.ToUInt16(buffer, buffer.Length - 2);
+                    MyPort = (ushort)((buffer[^2] << 8) | buffer[^1]);
 
                     //Log.Information("{MyIp}:{MyPort}", MyIp, MyPort);