fix(ui): main popup now shows 0 for empty schedule (#395)

This commit is contained in:
Rishthegreat
2024-10-27 17:11:51 -05:00
committed by GitHub
parent 2d0804f90e
commit 8de88d6ad7
2 changed files with 3 additions and 7 deletions

View File

@@ -59,15 +59,11 @@ messageListener.listen();
UserScheduleStore.listen('schedules', async schedules => { UserScheduleStore.listen('schedules', async schedules => {
const index = await UserScheduleStore.get('activeIndex'); const index = await UserScheduleStore.get('activeIndex');
const numCourses = schedules.newValue[index]?.courses?.length; const numCourses = schedules.newValue[index]?.courses?.length;
if (!numCourses) return; updateBadgeText(numCourses || 0);
updateBadgeText(numCourses);
}); });
UserScheduleStore.listen('activeIndex', async ({ newValue }) => { UserScheduleStore.listen('activeIndex', async ({ newValue }) => {
const schedules = await UserScheduleStore.get('schedules'); const schedules = await UserScheduleStore.get('schedules');
const numCourses = schedules[newValue]?.courses?.length; const numCourses = schedules[newValue]?.courses?.length;
if (!numCourses) return; updateBadgeText(numCourses || 0);
updateBadgeText(numCourses);
}); });

View File

@@ -14,7 +14,7 @@ export const BADGE_LIMIT = 10;
*/ */
export default function updateBadgeText(value: number): void { export default function updateBadgeText(value: number): void {
let badgeText = ''; let badgeText = '';
if (value > 0) { if (value >= 0) {
if (value > BADGE_LIMIT) { if (value > BADGE_LIMIT) {
badgeText = `${BADGE_LIMIT}+`; badgeText = `${BADGE_LIMIT}+`;
} else { } else {