Add permission for online/offline opening (Resolves #129) #136

2020-05-28T19:47:34-04:00

Phoenix616 commented

2020-05-28 19:47:34 -04:00

(Migrated from github.com)

This adds permissions for opening the inventories/enderchests of online and offline players separately. Not being allowed to open offline players also prevents any of the non-API player data loading but not the checking if the OfflinePlayer exists.

Jikoo (Migrated from github.com) approved these changes

2020-05-29 10:07:06 -04:00

Jikoo (Migrated from github.com) left a comment

Looks great, thank you!

Jikoo commented

2020-05-29 10:22:08 -04:00

(Migrated from github.com)

Just a heads up in case you are already using this - I am going to add the new nodes as children of the nodes OpenInv.openinv and OpenInv.openender for backwards compatibility with existing setups. That means that any group being granted either of those nodes will need the online/offline nodes negated again. It's not ideal, but I'm not ready to make breaking permissions changes yet and I do plan to eventually rework them to be consistent (and lower case).

Just a heads up in case you are already using this - I am going to add the new nodes as children of the nodes `OpenInv.openinv` and `OpenInv.openender` for backwards compatibility with existing setups. That means that any group being granted either of those nodes will need the online/offline nodes negated again. It's not ideal, but I'm not ready to make breaking permissions changes yet and I do plan to eventually rework them to be consistent (and lower case).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#136