Fix trapped chests linking with ordinary chests, instead of trapped ones #17

Merged

Hummer12007 merged 2 commits from master into master 2015-01-13 21:46:56 -05:00

Conversation 0 Commits 2 Files Changed 1

+4 -2

Hummer12007 commented 2015-01-13 15:04:23 -05:00 (Migrated from github.com)

Copy Link

Copy Source

The id->name block identification scheme change in Minecraft was reflected in the latest version of OpenInv: the block type, used for checking chest linking is no longer identified as the numerical ID of the block in question, but instead as a BlockChest type variable, which is always got as Block.getByName("chest"). This behavior ignored Trapped Chests in the check, and so linked both ordinary and trapped chests with ordinary ones. This caused a problem: if a trapped chest stands between two ordinary ones, it links with both of them, so the player gets a corrupt inventory view, reflecting contents of both three chests.
To fix this, BlockChest variable actually needs to reflect the type of the chest in question, so that it will appropriately link chest types.
The problem can easily be illustrated with the following screenshots:

1. Initial appearance of chest views (reflecting possible link situations):
   
   
   
   

2. Same chest views as of this commit:
   
   
   
   

The id->name block identification scheme change in Minecraft was reflected in the latest version of OpenInv: the block type, used for checking chest linking is no longer identified as the numerical ID of the block in question, but instead as a BlockChest type variable, which is always got as Block.getByName("chest"). This behavior ignored Trapped Chests in the check, and so linked both ordinary and trapped chests with ordinary ones. This caused a problem: if a trapped chest stands between two ordinary ones, it links with both of them, so the player gets a corrupt inventory view, reflecting contents of both three chests. To fix this, BlockChest variable actually needs to reflect the type of the chest in question, so that it will appropriately link chest types. The problem can easily be illustrated with the following screenshots: 1) Initial appearance of chest views (reflecting possible link situations):     2) Same chest views as of this commit:    

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Bug

Cannot Reproduce

Enhancement

Fixed

Invalid

Low Priority

Need More Information

Pending

Question

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

minster586 (minster586)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#17