Major update of the code #3

2012-05-25T04:47:51-04:00

Belphemur commented

2012-05-25 04:47:51 -04:00

(Migrated from github.com)

Hi,

As said in the message, here are ALL the fixes and optimization I applied in AdminCmd.

Most important ones are correction of the bug when opening an Offline Inventory, changing it and the player connect.

Also corrected in the other sense, opening inventory of a connected player and he disconnect.

Using a cache of the chest to avoid creation of other chest each time the command is called, permit to have more then 1 user on the same "chest".

Using the new Bukkit API : onClose() method.

Hi, As said in the message, here are ALL the fixes and optimization I applied in AdminCmd. Most important ones are correction of the bug when opening an Offline Inventory, changing it and the player connect. Also corrected in the other sense, opening inventory of a connected player and he disconnect. Using a cache of the chest to avoid creation of other chest each time the command is called, permit to have more then 1 user on the same "chest". Using the new Bukkit API : onClose() method.

lishid commented

2012-06-28 10:55:34 -04:00

(Migrated from github.com)

Thanks for the update, I manually merged it in and will close this pull request. Though there is a tiny problem with the code you provided (openinv an online player, player goes offline, edit inventory, player comes back online with old inventory). This was fixed as I merged the code.

Belphemur commented

2012-07-10 07:42:10 -04:00

(Migrated from github.com)

Thanks for the bug report :) I'll correct that on my code too.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/OpenInv#3