minster586/OpenInv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 36 Wiki Activity

* Fixed - player data glitch and online/offline events #41

Closed
cbarber wants to merge 2 commits from master into master
pull from: master
merge into: :master
Conversation 9 Commits 2 Files Changed 4
+2527 -6146
cbarber commented 2016-04-10 15:58:40 -04:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
Kakifrucht commented 2016-04-10 16:10:18 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Cool looks good, can you link a build where you have compiled it for testing?

Cool looks good, can you link a build where you have compiled it for testing?
RoboMWM commented 2016-04-11 14:28:51 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Could you add comments or explain what this does to fix the issue (or why you made the changes you made)? Would like a summary of what you're changing that fixes the issue...

Could you add comments or explain what this does to fix the issue (or why you made the changes you made)? Would like a summary of what you're changing that fixes the issue...
Kakifrucht commented 2016-04-11 16:44:24 -04:00 (Migrated from github.com)
Copy Link
Copy Source

@cbarber pls link compiled build 👶 thx appreciate it

@cbarber pls link compiled build :baby: thx appreciate it
RoboMWM commented 2016-04-11 17:23:25 -04:00 (Migrated from github.com)
Copy Link
Copy Source

@Kakifrucht are you not able to build via maven?

@Kakifrucht are you not able to build via maven?
Kakifrucht commented 2016-04-11 17:42:46 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Oh yeah, I guess I can, I just remembered that it required lots of old dependencies due to NMS. But that changed now.

Tested and seems to really fix the issue. Thanks alot!

Oh yeah, I guess I can, I just remembered that it required lots of old dependencies due to NMS. But that changed now. Tested and seems to really fix the issue. Thanks alot!
cbarber commented 2016-04-11 17:47:12 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Sorry, work has been busy today. In case anyone else needs a build, I tossed it on my fork: https://github.com/cbarber/OpenInv/blob/master/openinv-2.3.6.jar

Sorry, work has been busy today. In case anyone else needs a build, I tossed it on my fork: https://github.com/cbarber/OpenInv/blob/master/openinv-2.3.6.jar
❤️ 1
cbarber commented 2016-04-11 17:48:06 -04:00 (Migrated from github.com)
Copy Link
Copy Source

And somehow that commit was added to my PR. Sorry, I'm bad at these :/

And somehow that commit was added to my PR. Sorry, I'm bad at these :/
Jikoo commented 2016-04-11 19:10:27 -04:00 (Migrated from github.com)
Copy Link
Copy Source

I suggest using the release system rather than pushing commits with binaries. Anything you push to the branch you opened the pull from Github will add to the pull. Just hard reset head to the old commit and force a push to overwrite the branch.

In case you don't see #40

The root of the issue is that SpecialPlayerInventory#playerOnline does not update PlayerInventory.player or SpecialPlayerInventory.owner. The same sort of applies to ender chests, though they don't suffer a duplication or desync bug because of it.

I suggest using the [release system](https://github.com/cbarber/OpenInv/releases) rather than pushing commits with binaries. Anything you push to the branch you opened the pull from Github will add to the pull. Just hard reset head to the old commit and force a push to overwrite the branch. In case you don't see #40 > The root of the issue is that SpecialPlayerInventory#playerOnline does not update PlayerInventory.player or SpecialPlayerInventory.owner. The same sort of applies to ender chests, though they don't suffer a duplication or desync bug because of it.
👍 1
ShadowRanger commented 2016-04-12 00:40:28 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks cbarber for implementing this fix and making these changes. I've copied your changes into my fork which I've just merged the pull request of into OpenInv. I will release the updated version of the plugin to BukkitDev within the next couple of days. Please let me know if there are any other changes or issues before I do so. Thanks again.

Thanks cbarber for implementing this fix and making these changes. I've copied your changes into my fork which I've just merged the pull request of into OpenInv. I will release the updated version of the plugin to BukkitDev within the next couple of days. Please let me know if there are any other changes or issues before I do so. Thanks again.
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Cannot Reproduce
Enhancement
Fixed
Invalid
Low Priority
Need More Information
Pending
Question
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
minster586 (minster586)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: minster586/OpenInv#41