Add time adjustment #10

New Issue

2024-07-26T18:01:39-04:00

MightyX3N commented

2024-07-26 18:01:39 -04:00

(Migrated from github.com)

Is there already a request similar to this?

There are not and have never been any feature requests similar to this

What's your suggestion?

The site https://sunrisesunset.io/ does not update their data in real time, so maybe you could add a time adjustment setting to the config, so there could be added a custom amount of time, for example +2 hours to match real time,

as you can see here: https://sunrisesunset.io/search/denmark/ it says last update was 2 hours ago

### Is there already a request similar to this? - [X] There are not and have never been any feature requests similar to this ### What's your suggestion? The site https://sunrisesunset.io/ does not update their data in real time, so maybe you could add a time adjustment setting to the config, so there could be added a custom amount of time, for example +2 hours to match real time, as you can see here: https://sunrisesunset.io/search/denmark/ it says last update was 2 hours ago

Jack1424 commented

2024-07-26 19:19:34 -04:00

(Migrated from github.com)

RealTimeWeather only gets the sunrise and sunset times from the current day from sunrisesunset.io, not the current time. It gets the current time from the system clock of the server that it's running on and adjusts according to the timezone in the configuration.

Realistically, RealTimeWeather doesn't need to check the sunrise and sunset times every few seconds, and I'm working on moving API requests separate from the time update code soon, but it's ok if sunrisesunset.io hasn't been updated super recently.

I could add an option to offset the time, but you're better off just changing the timezone.

RealTimeWeather only gets the sunrise and sunset times from the current day from sunrisesunset.io, not the current time. It gets the current time from the system clock of the server that it's running on and adjusts according to the timezone in the configuration. Realistically, RealTimeWeather doesn't need to check the sunrise and sunset times every few seconds, and I'm working on moving API requests separate from the time update code soon, but it's ok if sunrisesunset.io hasn't been updated super recently. I could add an option to offset the time, but you're better off just changing the timezone.

MightyX3N commented

2024-07-27 05:25:49 -04:00

(Migrated from github.com)

well then the plugin is not working correctly, im running the server locally developing it, the time in game says 05:02 but the time locally is 11:25,

and the ingame time dont seem to change at all

well then the plugin is not working correctly, im running the server locally developing it, the time in game says 05:02 but the time locally is 11:25, and the ingame time dont seem to change at all

Jack1424 commented

2024-08-06 21:09:53 -04:00

(Migrated from github.com)

This issue was fixed with #12

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: minster586/RealTimeWeather#10