docs: updated pagination, upped version to 5.1.1

dev: removed some old creds migration code, incremented creds version

CHANGELOG.md

@@ -2,6 +2,20 @@
 
 Mostly based on [keepachangelog](https://keepachangelog.com/en/1.0.0/) except date format. a-c-f-r-o
 
+## [5.1.1] - 27.06.2024
+
+### Added
+
+- Added `.honeypot` command, which automatically softbans (ban and immediate unban) any user who posts in that channel.
+  - Useful to auto softban bots who spam every channel upon joining
+  - Users who run commands or expressions won't be softbanned. 
+  - Users who have ban member permissions are also excluded.
+
+### Fixed
+
+- Fixed `.betdraw` not respecting maxbet
+- Fixed `.xpshop` pagination for real this time?
+
 ## [5.1.0] - 25.06.2024
 
 ### Added
@@ -10,9 +24,9 @@ Mostly based on [keepachangelog](https://keepachangelog.com/en/1.0.0/) except da
   - You can send natural language questions, queries or execute commands. For example "@Nadeko how's the weather in paris" and it will return `.we Paris` and run it for you.
   - In case the bot can't execute a command using your query, It will fall back to your chatter bot, in case you have it enabled in data/games.yml. (Cleverbot or chatgpt)
   - (It's far from perfect so please don't ask the bot to do dangerous things like banning or pruning)
-  - Requires Patreon subscription, after which you'll be able to run it on global @Nadeko bot. If you're selfhosting, you also will need to acquire the api key from <https://dashy.nadeko.bot/api> (coming soon(ish)...)
+  - Requires Patreon subscription, after which you'll be able to run it on global @Nadeko bot. 
+    - Selfhosters: If you're selfhosting, you also will need to acquire the api key from <https://dashy.nadeko.bot/me> after pledging on patreon and put it in nadekoAiToken in creds.yml
 - Added support for `gpt-4o` in `data/games.yml`
-- Added nadekoAiToken to `creds.yml`
 
 
 ### Changed

src/NadekoBot/Bot.cs

@@ -93,7 +93,7 @@ public sealed class Bot : IBot
     private void AddServices()
     {
         var startingGuildIdList = GetCurrentGuildIds();
-        var sw = Stopwatch.StartNew();
+        var startTime = Stopwatch.GetTimestamp();
         var bot = Client.CurrentUser;
 
         using (var uow = _db.GetDbContext())
@@ -160,9 +160,8 @@ public sealed class Bot : IBot
         {
             LoadTypeReaders(a);
         }
-
-        sw.Stop();
-        Log.Information("All services loaded in {ServiceLoadTime:F2}s", sw.Elapsed.TotalSeconds);
+        
+        Log.Information("All services loaded in {ServiceLoadTime:F2}s", Stopwatch.GetElapsedTime(startTime) .TotalSeconds);
     }
 
     private void LoadTypeReaders(Assembly assembly)
@@ -259,7 +258,7 @@ public sealed class Bot : IBot
         if (ShardId == 0)
             await _db.SetupAsync();
 
-        var sw = Stopwatch.StartNew();
+        var startTime = Stopwatch.GetTimestamp();
 
         await LoginAsync(_creds.Token);
         
@@ -274,8 +273,7 @@ public sealed class Bot : IBot
             Helpers.ReadErrorAndExit(9);
         }
 
-        sw.Stop();
-        Log.Information("Shard {ShardId} connected in {Elapsed:F2}s", Client.ShardId, sw.Elapsed.TotalSeconds);
+        Log.Information("Shard {ShardId} connected in {Elapsed:F2}s", Client.ShardId, Stopwatch.GetElapsedTime(startTime).TotalSeconds);
         var commandHandler = Services.GetRequiredService<CommandHandler>();
 
         // start handling messages received in commandhandler

src/NadekoBot/Db/Models/HoneypotChannel.cs

@@ -0,0 +1,11 @@
+using System.ComponentModel.DataAnnotations;
+
+namespace NadekoBot.Db.Models;
+
+public class HoneypotChannel
+{
+    [Key]
+    public ulong GuildId { get; set; }
+    
+    public ulong ChannelId { get; set; }
+}

src/NadekoBot/Db/NadekoContext.cs

@@ -59,6 +59,7 @@ public abstract class NadekoContext : DbContext
 
     public DbSet<TodoModel> Todos { get; set; }
     public DbSet<ArchivedTodoListModel> TodosArchive { get; set; }
+    public DbSet<HoneypotChannel> HoneyPotChannels { get; set; }
 
     // todo add guild colors
     // public DbSet<GuildColors> GuildColors { get; set; }

src/NadekoBot/Migrations/Mysql/20240627033532_honeypot.cs

@@ -0,0 +1,36 @@
+using Microsoft.EntityFrameworkCore.Metadata;
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace NadekoBot.Migrations.Mysql
+{
+    /// <inheritdoc />
+    public partial class honeypot : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.CreateTable(
+                name: "honeypotchannels",
+                columns: table => new
+                {
+                    guildid = table.Column<ulong>(type: "bigint unsigned", nullable: false)
+                        .Annotation("MySql:ValueGenerationStrategy", MySqlValueGenerationStrategy.IdentityColumn),
+                    channelid = table.Column<ulong>(type: "bigint unsigned", nullable: false)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("pk_honeypotchannels", x => x.guildid);
+                })
+                .Annotation("MySql:CharSet", "utf8mb4");
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "honeypotchannels");
+        }
+    }
+}

src/NadekoBot/Migrations/Mysql/MysqlContextModelSnapshot.cs

@@ -1388,6 +1388,25 @@ namespace NadekoBot.Migrations.Mysql
                     b.ToTable("guildconfigs", (string)null);
                 });
 
+            modelBuilder.Entity("NadekoBot.Db.Models.HoneypotChannel", b =>
+                {
+                    b.Property<ulong>("GuildId")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("bigint unsigned")
+                        .HasColumnName("guildid");
+
+                    MySqlPropertyBuilderExtensions.UseMySqlIdentityColumn(b.Property<ulong>("GuildId"));
+
+                    b.Property<ulong>("ChannelId")
+                        .HasColumnType("bigint unsigned")
+                        .HasColumnName("channelid");
+
+                    b.HasKey("GuildId")
+                        .HasName("pk_honeypotchannels");
+
+                    b.ToTable("honeypotchannels", (string)null);
+                });
+
             modelBuilder.Entity("NadekoBot.Db.Models.IgnoredLogItem", b =>
                 {
                     b.Property<int>("Id")

src/NadekoBot/Migrations/PostgreSql/20240627033522_honeypot.cs

@@ -0,0 +1,33 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace NadekoBot.Migrations.PostgreSql
+{
+    /// <inheritdoc />
+    public partial class honeypot : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.CreateTable(
+                name: "honeypotchannels",
+                columns: table => new
+                {
+                    guildid = table.Column<decimal>(type: "numeric(20,0)", nullable: false),
+                    channelid = table.Column<decimal>(type: "numeric(20,0)", nullable: false)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("pk_honeypotchannels", x => x.guildid);
+                });
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "honeypotchannels");
+        }
+    }
+}

src/NadekoBot/Migrations/PostgreSql/PostgreSqlContextModelSnapshot.cs

@@ -1387,6 +1387,23 @@ namespace NadekoBot.Migrations.PostgreSql
                     b.ToTable("guildconfigs", (string)null);
                 });
 
+            modelBuilder.Entity("NadekoBot.Db.Models.HoneypotChannel", b =>
+                {
+                    b.Property<decimal>("GuildId")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("numeric(20,0)")
+                        .HasColumnName("guildid");
+
+                    b.Property<decimal>("ChannelId")
+                        .HasColumnType("numeric(20,0)")
+                        .HasColumnName("channelid");
+
+                    b.HasKey("GuildId")
+                        .HasName("pk_honeypotchannels");
+
+                    b.ToTable("honeypotchannels", (string)null);
+                });
+
             modelBuilder.Entity("NadekoBot.Db.Models.IgnoredLogItem", b =>
                 {
                     b.Property<int>("Id")

src/NadekoBot/Migrations/Sqlite/20240627033508_honeypot.cs

@@ -0,0 +1,34 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace NadekoBot.Migrations
+{
+    /// <inheritdoc />
+    public partial class honeypot : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.CreateTable(
+                name: "HoneyPotChannels",
+                columns: table => new
+                {
+                    GuildId = table.Column<ulong>(type: "INTEGER", nullable: false)
+                        .Annotation("Sqlite:Autoincrement", true),
+                    ChannelId = table.Column<ulong>(type: "INTEGER", nullable: false)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("PK_HoneyPotChannels", x => x.GuildId);
+                });
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "HoneyPotChannels");
+        }
+    }
+}

src/NadekoBot/Migrations/Sqlite/NadekoSqliteContextModelSnapshot.cs

@@ -1033,6 +1033,20 @@ namespace NadekoBot.Migrations
                     b.ToTable("GuildConfigs");
                 });
 
+            modelBuilder.Entity("NadekoBot.Db.Models.HoneypotChannel", b =>
+                {
+                    b.Property<ulong>("GuildId")
+                        .ValueGeneratedOnAdd()
+                        .HasColumnType("INTEGER");
+
+                    b.Property<ulong>("ChannelId")
+                        .HasColumnType("INTEGER");
+
+                    b.HasKey("GuildId");
+
+                    b.ToTable("HoneyPotChannels");
+                });
+
             modelBuilder.Entity("NadekoBot.Db.Models.IgnoredLogItem", b =>
                 {
                     b.Property<int>("Id")

src/NadekoBot/Modules/Administration/Honeypot/HoneyPotService.cs

@@ -0,0 +1,94 @@
+using LinqToDB;
+using LinqToDB.EntityFrameworkCore;
+using NadekoBot.Common.ModuleBehaviors;
+using NadekoBot.Db.Models;
+using System.Threading.Channels;
+
+namespace NadekoBot.Modules.Administration.Honeypot;
+
+public sealed class HoneyPotService : IHoneyPotService, IReadyExecutor, IExecNoCommand, INService
+{
+    private readonly DbService _db;
+    private readonly CommandHandler _handler;
+
+    private ConcurrentHashSet<ulong> _channels = new();
+
+    private Channel<SocketGuildUser> _punishments = Channel.CreateBounded<SocketGuildUser>(
+        new BoundedChannelOptions(100)
+        {
+            FullMode = BoundedChannelFullMode.DropOldest,
+            SingleReader = true,
+            SingleWriter = false,
+        });
+
+    public HoneyPotService(DbService db, CommandHandler handler)
+    {
+        _db = db;
+        _handler = handler;
+    }
+
+    public async Task<bool> ToggleHoneypotChannel(ulong guildId, ulong channelId)
+    {
+        await using var uow = _db.GetDbContext();
+
+        var deleted = await uow.HoneyPotChannels
+                               .Where(x => x.GuildId == guildId)
+                               .DeleteWithOutputAsync();
+
+        if (deleted.Length > 0)
+        {
+            _channels.TryRemove(deleted[0].ChannelId);
+            return false;
+        }
+
+        await uow.HoneyPotChannels
+                 .ToLinqToDBTable()
+                 .InsertAsync(() => new HoneypotChannel
+                 {
+                     GuildId = guildId,
+                     ChannelId = channelId
+                 });
+
+        _channels.Add(channelId);
+
+        return true;
+    }
+
+    public async Task OnReadyAsync()
+    {
+        await using var uow = _db.GetDbContext();
+
+        var channels = await uow.HoneyPotChannels
+                                .Select(x => x.ChannelId)
+                                .ToListAsyncLinqToDB();
+
+        _channels = new(channels);
+
+        while (await _punishments.Reader.WaitToReadAsync())
+        {
+            while (_punishments.Reader.TryRead(out var user))
+            {
+                try
+                {
+                    Log.Information("Honeypot caught user {User} [{UserId}]", user, user.Id);
+                    await user.BanAsync();
+                }
+                catch (Exception e)
+                {
+                    Log.Warning(e, "Failed banning {User} due to {Error}", user, e.Message);
+                }
+
+                await Task.Delay(1000);
+            }
+        }
+    }
+
+    public async Task ExecOnNoCommandAsync(IGuild guild, IUserMessage msg)
+    {
+        if (_channels.Contains(msg.Channel.Id) && msg.Author is SocketGuildUser sgu)
+        {
+            if (!sgu.GuildPermissions.BanMembers)
+                await _punishments.Writer.WriteAsync(sgu);
+        }
+    }
+}

src/NadekoBot/Modules/Administration/Honeypot/HoneypotCommands.cs

@@ -0,0 +1,29 @@
+using NadekoBot.Modules.Administration.Honeypot;
+
+namespace NadekoBot.Modules.Administration;
+
+public partial class Administration
+{
+    [Group]
+    public partial class HoneypotCommands : NadekoModule
+    {
+        private readonly IHoneyPotService _service;
+
+        public HoneypotCommands(IHoneyPotService service)
+            => _service = service;
+
+        [Cmd]
+        [RequireContext(ContextType.Guild)]
+        [RequireUserPermission(GuildPermission.Administrator)]
+        [RequireBotPermission(GuildPermission.BanMembers)]
+        public async Task Honeypot()
+        {
+            var enabled = await _service.ToggleHoneypotChannel(ctx.Guild.Id, ctx.Channel.Id);
+
+            if (enabled)
+                await Response().Confirm(strs.honeypot_on).SendAsync();
+            else
+                await Response().Confirm(strs.honeypot_off).SendAsync();
+        }
+    }
+}

src/NadekoBot/Modules/Administration/Honeypot/IHoneyPotService.cs

@@ -0,0 +1,6 @@
+namespace NadekoBot.Modules.Administration.Honeypot;
+
+public interface IHoneyPotService
+{
+    public Task<bool> ToggleHoneypotChannel(ulong guildId, ulong channelId);
+}

src/NadekoBot/Modules/Gambling/Draw/DrawCommands.cs

@@ -17,7 +17,8 @@ public partial class Gambling
         private static readonly ConcurrentDictionary<IGuild, Deck> _allDecks = new();
         private readonly IImageCache _images;
 
-        public DrawCommands(IImageCache images, GamblingConfigService gcs) : base(gcs)
+        public DrawCommands(IImageCache images, GamblingConfigService gcs)
+            : base(gcs)
             => _images = images;
 
         private async Task InternalDraw(int count, ulong? guildId = null)
@@ -56,8 +57,8 @@ public partial class Gambling
                 i.Dispose();
 
             var eb = _sender.CreateEmbed()
-                .WithOkColor();
-            
+                            .WithOkColor();
+
             var toSend = string.Empty;
             if (cardObjects.Count == 5)
                 eb.AddField(GetText(strs.hand_value), Deck.GetHandValue(cardObjects), true);
@@ -71,7 +72,7 @@ public partial class Gambling
 
             if (count > 1)
                 eb.AddField(GetText(strs.cards), count.ToString(), true);
-                
+
             await using var imageStream = await img.ToStreamAsync();
             await ctx.Channel.SendFileAsync(imageStream,
                 imgName,
@@ -84,7 +85,7 @@ public partial class Gambling
             var cardBytes = await File.ReadAllBytesAsync($"data/images/cards/{cardName}.jpg");
             return Image.Load<Rgba32>(cardBytes);
         }
-        
+
         private async Task<Image<Rgba32>> GetCardImageAsync(Deck.Card currentCard)
         {
             var cardName = currentCard.ToString().ToLowerInvariant().Replace(' ', '_');
@@ -98,7 +99,7 @@ public partial class Gambling
         {
             if (num < 1)
                 return;
-            
+
             if (num > 10)
                 num = 10;
 
@@ -110,7 +111,7 @@ public partial class Gambling
         {
             if (num < 1)
                 return;
-            
+
             if (num > 10)
                 num = 10;
 
@@ -136,19 +137,29 @@ public partial class Gambling
 
         [Cmd]
         [RequireContext(ContextType.Guild)]
-        public Task BetDraw([OverrideTypeReader(typeof(BalanceTypeReader))] long amount, InputValueGuess val, InputColorGuess? col = null)
+        public Task BetDraw(
+            [OverrideTypeReader(typeof(BalanceTypeReader))]
+            long amount,
+            InputValueGuess val,
+            InputColorGuess? col = null)
             => BetDrawInternal(amount, val, col);
-        
+
         [Cmd]
         [RequireContext(ContextType.Guild)]
-        public Task BetDraw([OverrideTypeReader(typeof(BalanceTypeReader))] long amount, InputColorGuess col, InputValueGuess? val = null)
+        public Task BetDraw(
+            [OverrideTypeReader(typeof(BalanceTypeReader))]
+            long amount,
+            InputColorGuess col,
+            InputValueGuess? val = null)
             => BetDrawInternal(amount, val, col);
-        
+
         public async Task BetDrawInternal(long amount, InputValueGuess? val, InputColorGuess? col)
         {
-            if (amount <= 0)
+            if (!await CheckBetMandatory(amount))
+            {
                 return;
-            
+            }
+
             var res = await _service.BetDrawAsync(ctx.User.Id,
                 amount,
                 (byte?)val,
@@ -161,13 +172,13 @@ public partial class Gambling
             }
 
             var eb = _sender.CreateEmbed()
-                .WithOkColor()
-                .WithAuthor(ctx.User)
-                .WithDescription(result.Card.GetEmoji())
-                .AddField(GetText(strs.guess), GetGuessInfo(val, col), true)
-                .AddField(GetText(strs.card), GetCardInfo(result.Card), true)
-                .AddField(GetText(strs.won), N((long)result.Won), false)
-                .WithImageUrl("attachment://card.png");
+                            .WithOkColor()
+                            .WithAuthor(ctx.User)
+                            .WithDescription(result.Card.GetEmoji())
+                            .AddField(GetText(strs.guess), GetGuessInfo(val, col), true)
+                            .AddField(GetText(strs.card), GetCardInfo(result.Card), true)
+                            .AddField(GetText(strs.won), N((long)result.Won), false)
+                            .WithImageUrl("attachment://card.png");
 
             using var img = await GetCardImageAsync(result.Card);
             await using var imgStream = await img.ToStreamAsync();
@@ -189,9 +200,10 @@ public partial class Gambling
                 InputColorGuess.Black => "B ⚫",
                 _ => "❓"
             };
-            
+
             return $"{val} / {col}";
         }
+
         private string GetCardInfo(RegularCard card)
         {
             var val = (int)card.Value switch
@@ -208,7 +220,7 @@ public partial class Gambling
                     RegularSuit.Diamonds or RegularSuit.Hearts => "R 🔴",
                     _ => "B ⚫"
                 };
-            
+
             return $"{val} / {col}";
         }
 

src/NadekoBot/Modules/Games/ChatterBot/ChatterBotService.cs

@@ -165,7 +165,7 @@ public class ChatterBotService : IExecOnMessage
             }
             else
             {
-                Log.Warning("Error in chatterbot: {Error}", error);
+                Log.Warning("Error in chatterbot: {Error}", error.Value);
             }
 
             Log.Information("""

src/NadekoBot/Modules/Games/ChatterBot/_common/OfficialGptSession.cs

@@ -103,6 +103,8 @@ public class OfficialGptSession : IChatterBotSession
         try
         {
             var response = JsonConvert.DeserializeObject<OpenAiCompletionResponse>(dataString);
+            
+            Log.Information("Received response: {response} ", dataString);
             var res = response?.Choices?[0];
             var message = res?.Message?.Content;
 

src/NadekoBot/Modules/Searches/Search/Searx/SearxSearchService.cs

@@ -32,20 +32,21 @@ public sealed class SearxSearchService : SearchServiceBase, INService
         var instanceUrl = GetRandomInstance();
         
         Log.Information("Using {Instance} instance for web search...", instanceUrl);
-        var sw = Stopwatch.StartNew();
+        var startTime = Stopwatch.GetTimestamp();
+        
         using var http = _http.CreateClient();
         await using var res = await http.GetStreamAsync($"{instanceUrl}"
                                                         + $"?q={Uri.EscapeDataString(query)}"
                                                         + $"&format=json"
                                                         + $"&strict=2");
 
-        sw.Stop();
+        var elapsed = Stopwatch.GetElapsedTime(startTime);
         var dat = await JsonSerializer.DeserializeAsync<SearxSearchResult>(res);
 
         if (dat is null)
             return new SearxSearchResult();
         
-        dat.SearchTime = sw.Elapsed.TotalSeconds.ToString("N2", CultureInfo.InvariantCulture); 
+        dat.SearchTime = elapsed.TotalSeconds.ToString("N2", CultureInfo.InvariantCulture); 
         return dat;
     }
 
@@ -56,7 +57,7 @@ public sealed class SearxSearchService : SearchServiceBase, INService
         var instanceUrl = GetRandomInstance();
         
         Log.Information("Using {Instance} instance for img search...", instanceUrl);
-        var sw = Stopwatch.StartNew();
+        var startTime = Stopwatch.GetTimestamp();
         using var http = _http.CreateClient();
         await using var res = await http.GetStreamAsync($"{instanceUrl}"
                                                         + $"?q={Uri.EscapeDataString(query)}"
@@ -64,13 +65,13 @@ public sealed class SearxSearchService : SearchServiceBase, INService
                                                         + $"&category_images=on"
                                                         + $"&strict=2");
 
-        sw.Stop();
+        var elapsed = Stopwatch.GetElapsedTime(startTime);
         var dat = await JsonSerializer.DeserializeAsync<SearxImageSearchResult>(res);
 
         if (dat is null)
             return new SearxImageSearchResult();
         
-        dat.SearchTime = sw.Elapsed.TotalSeconds.ToString("N2", CultureInfo.InvariantCulture); 
+        dat.SearchTime = elapsed.TotalSeconds.ToString("N2", CultureInfo.InvariantCulture); 
         return dat;
     }
 }

src/NadekoBot/Modules/Utility/Ai/CommandPromptResultModel.cs

@@ -8,9 +8,9 @@ public sealed class CommandPromptResultModel
     public required string Name { get; set; }
 
     [JsonPropertyName("arguments")]
-    public required Dictionary<string, string> Arguments { get; set; }
-    
+    public Dictionary<string, string> Arguments { get; set; } = new();
+
     [JsonPropertyName("remaining")]
     [JsonConverter(typeof(NumberToStringConverter))]
-    public required string Remaining { get; set; }
+    public string Remaining { get; set; } = string.Empty;
 }

src/NadekoBot/Modules/Xp/Xp.cs

@@ -480,7 +480,8 @@ public partial class Xp : NadekoModule<XpService>
                           ctx.User.Id,
                           button,
                           OnShopUse,
-                          (key, itemType));
+                          (key, itemType),
+                          clearAfter: false);
 
                       return inter;
                   }
@@ -494,7 +495,9 @@ public partial class Xp : NadekoModule<XpService>
                           ctx.User.Id,
                           button,
                           OnShopBuy,
-                          (key, itemType));
+                          (key, itemType),
+                          singleUse: true,
+                          clearAfter: false);
 
                       return inter;
                   }
@@ -577,6 +580,10 @@ public partial class Xp : NadekoModule<XpService>
         {
             await Response().Error(strs.not_enough(_gss.GetCurrencySign())).SendAsync();
         }
+        else if (result == BuyResult.Success)
+        {
+            await _service.UseShopItemAsync(ctx.User.Id, type, key);
+        }
     }
 
     private string GetNotifLocationString(XpNotificationLocation loc)

src/NadekoBot/NadekoBot.csproj

@@ -4,7 +4,7 @@
         <Nullable>enable</Nullable>
         <ImplicitUsings>true</ImplicitUsings>
         <SatelliteResourceLanguages>en</SatelliteResourceLanguages>
-        <Version>5.1.0</Version>
+        <Version>5.1.1</Version>
 
         <!-- Output/build -->
         <RunWorkingDirectory>$(MSBuildProjectDirectory)</RunWorkingDirectory>
@@ -73,7 +73,7 @@
         <PackageReference Include="SixLabors.ImageSharp" Version="2.1.8"/>
         <PackageReference Include="SixLabors.ImageSharp.Drawing" Version="1.0.0-beta14"/>
         <PackageReference Include="SixLabors.Shapes" Version="1.0.0-beta0009"/>
-        <PackageReference Include="StackExchange.Redis" Version="2.7.33"/>
+        <PackageReference Include="StackExchange.Redis" Version="2.8.0" />
         <PackageReference Include="YamlDotNet" Version="15.1.4"/>
         <PackageReference Include="SharpToken" Version="2.0.3" />
 

src/NadekoBot/Services/Impl/BotCredsProvider.cs

@@ -133,52 +133,8 @@ public sealed class BotCredsProvider : IBotCredsProvider
         File.WriteAllText(CREDS_FILE_NAME, ymlData);
     }
 
-    private string OldCredsJsonPath
-        => Path.Combine(Directory.GetCurrentDirectory(), "credentials.json");
-
-    private string OldCredsJsonBackupPath
-        => Path.Combine(Directory.GetCurrentDirectory(), "credentials.json.bak");
-
     private void MigrateCredentials()
     {
-        if (File.Exists(OldCredsJsonPath))
-        {
-            Log.Information("Migrating old creds...");
-            var jsonCredentialsFileText = File.ReadAllText(OldCredsJsonPath);
-            var oldCreds = JsonConvert.DeserializeObject<OldCreds>(jsonCredentialsFileText);
-
-            if (oldCreds is null)
-            {
-                Log.Error("Error while reading old credentials file. Make sure that the file is formatted correctly");
-                return;
-            }
-
-            var creds = new Creds
-            {
-                Version = 1,
-                Token = oldCreds.Token,
-                OwnerIds = oldCreds.OwnerIds.Distinct().ToHashSet(),
-                GoogleApiKey = oldCreds.GoogleApiKey,
-                RapidApiKey = oldCreds.MashapeKey,
-                OsuApiKey = oldCreds.OsuApiKey,
-                CleverbotApiKey = oldCreds.CleverbotApiKey,
-                TotalShards = oldCreds.TotalShards <= 1 ? 1 : oldCreds.TotalShards,
-                Patreon = new Creds.PatreonSettings(oldCreds.PatreonAccessToken, null, null, oldCreds.PatreonCampaignId),
-                Votes = new Creds.VotesSettings(oldCreds.VotesUrl, oldCreds.VotesToken, string.Empty, string.Empty),
-                BotListToken = oldCreds.BotListToken,
-                RedisOptions = oldCreds.RedisOptions,
-                LocationIqApiKey = oldCreds.LocationIqApiKey,
-                TimezoneDbApiKey = oldCreds.TimezoneDbApiKey,
-                CoinmarketcapApiKey = oldCreds.CoinmarketcapApiKey
-            };
-
-            File.Move(OldCredsJsonPath, OldCredsJsonBackupPath, true);
-            File.WriteAllText(CredsPath, Yaml.Serializer.Serialize(creds));
-
-            Log.Warning(
-                "Data from credentials.json has been moved to creds.yml\nPlease inspect your creds.yml for correctness");
-        }
-
         if (File.Exists(CREDS_FILE_NAME))
         {
             var creds = Yaml.Deserializer.Deserialize<Creds>(File.ReadAllText(CREDS_FILE_NAME));
@@ -192,9 +148,9 @@ public sealed class BotCredsProvider : IBotCredsProvider
                 File.WriteAllText(CREDS_FILE_NAME, Yaml.Serializer.Serialize(creds));
             }
 
-            if (creds.Version <= 7)
+            if (creds.Version <= 8)
             {
-                creds.Version = 8;
+                creds.Version = 9;
                 File.WriteAllText(CREDS_FILE_NAME, Yaml.Serializer.Serialize(creds));
             }
         }

src/NadekoBot/_common/Creds.cs

@@ -31,10 +31,10 @@ public sealed class Creds : IBotCredentials
 
     [Comment("""
              Pledge 5$ or more on https://patreon.com/nadekobot and connect your discord account to Patreon.
-             Go to https://dashy.nadeko.bot and login with your discord account
+             Go to https://dashy.nadeko.bot/me and login with your discord account
              Go to the Keys page and click "Generate New Key" and copy it here
              You and anyone else with the permission to run `.prompt` command will be able to use natural language to run bot's commands.
-             For example '@Bot how's the weather in Paris' will return the current weather in Paris as if you were to run `.weather Paris` command
+             For example '@Bot how's the weather in Paris' will return the current weather in Paris as if you were to run `.weather Paris` command.
              """)]
     public string NadekoAiToken { get; set; }
     
@@ -156,7 +156,7 @@ public sealed class Creds : IBotCredentials
 
     public Creds()
     {
-        Version = 7;
+        Version = 9;
         Token = string.Empty;
         UsePrivilegedIntents = true;
         OwnerIds = new List<ulong>();

src/NadekoBot/_common/Interaction/INadekoInteractionService.cs

@@ -6,14 +6,16 @@ public interface INadekoInteractionService
         ulong userId,
         ButtonBuilder button,
         Func<SocketMessageComponent, Task> onTrigger,
-        bool singleUse = true);
+        bool singleUse = true,
+        bool clearAfter = true);
 
     public NadekoInteractionBase Create<T>(
         ulong userId,
         ButtonBuilder button,
         Func<SocketMessageComponent, T, Task> onTrigger,
         in T state,
-        bool singleUse = true);
+        bool singleUse = true,
+        bool clearAfter = true);
 
     NadekoInteractionBase Create(
         ulong userId,

src/NadekoBot/_common/Interaction/Models/NadekoButtonInteraction.cs

@@ -8,8 +8,9 @@ public sealed class NadekoButtonInteractionHandler : NadekoInteractionBase
         ButtonBuilder button,
         Func<SocketMessageComponent, Task> onAction,
         bool onlyAuthor,
-        bool singleUse = true)
-        : base(client, authorId, button.CustomId, onAction, onlyAuthor, singleUse)
+        bool singleUse = true,
+        bool clearAfter = true)
+        : base(client, authorId, button.CustomId, onAction, onlyAuthor, singleUse, clearAfter)
     {
         Button = button;
     }

src/NadekoBot/_common/Interaction/NadekoInteraction.cs

@@ -12,6 +12,7 @@ public abstract class NadekoInteractionBase
     private IUserMessage message = null!;
     private readonly string _customId;
     private readonly bool _singleUse;
+    private readonly bool _clearAfter;
 
     public NadekoInteractionBase(
         DiscordSocketClient client,
@@ -19,13 +20,16 @@ public abstract class NadekoInteractionBase
         string customId,
         Func<SocketMessageComponent, Task> onAction,
         bool onlyAuthor,
-        bool singleUse = true)
+        bool singleUse = true,
+        bool clearAfter = true)
     {
         _authorId = authorId;
         _customId = customId;
         _onAction = onAction;
         _onlyAuthor = onlyAuthor;
         _singleUse = singleUse;
+        _clearAfter = clearAfter;
+        
         _interactionCompletedSource = new(TaskCreationOptions.RunContinuationsAsynchronously);
 
         Client = client;
@@ -36,13 +40,11 @@ public abstract class NadekoInteractionBase
         message = msg;
 
         Client.InteractionCreated += OnInteraction;
-        if (_singleUse)
-            await Task.WhenAny(Task.Delay(30_000), _interactionCompletedSource.Task);
-        else
-            await Task.Delay(30_000);
+        await Task.WhenAny(Task.Delay(30_000), _interactionCompletedSource.Task);
         Client.InteractionCreated -= OnInteraction;
 
-        await msg.ModifyAsync(m => m.Components = new ComponentBuilder().Build());
+        if (_clearAfter)
+            await msg.ModifyAsync(m => m.Components = new ComponentBuilder().Build());
     }
 
     private Task OnInteraction(SocketInteraction arg)
@@ -59,11 +61,15 @@ public abstract class NadekoInteractionBase
         if (smc.Data.CustomId != _customId)
             return Task.CompletedTask;
 
+        if (_interactionCompletedSource.Task.IsCompleted)
+            return Task.CompletedTask;
+
         _ = Task.Run(async () =>
         {
             try
             {
-                _interactionCompletedSource.TrySetResult(true);
+                if (_singleUse)
+                    _interactionCompletedSource.TrySetResult(true);
                 await ExecuteOnActionAsync(smc);
 
                 if (!smc.HasResponded)

src/NadekoBot/_common/Interaction/NadekoInteractionService.cs

@@ -13,25 +13,30 @@ public class NadekoInteractionService : INadekoInteractionService, INService
         ulong userId,
         ButtonBuilder button,
         Func<SocketMessageComponent, Task> onTrigger,
-        bool singleUse = true)
+        bool singleUse = true,
+        bool clearAfter = true)
         => new NadekoButtonInteractionHandler(_client,
             userId,
             button,
             onTrigger,
             onlyAuthor: true,
-            singleUse: singleUse);
+            singleUse: singleUse,
+            clearAfter: clearAfter);
 
     public NadekoInteractionBase Create<T>(
         ulong userId,
         ButtonBuilder button,
         Func<SocketMessageComponent, T, Task> onTrigger,
         in T state,
-        bool singleUse = true)
+        bool singleUse = true,
+        bool clearAfter = true
+    )
         => Create(userId,
             button,
             ((Func<T, Func<SocketMessageComponent, Task>>)((data)
                 => smc => onTrigger(smc, data)))(state),
-            singleUse);
+            singleUse,
+            clearAfter);
 
     public NadekoInteractionBase Create(
         ulong userId,

src/NadekoBot/_common/OldCreds.cs

@@ -1,45 +0,0 @@
-#nullable disable
-namespace NadekoBot.Common;
-
-public class OldCreds
-{
-    public string Token { get; set; } = string.Empty;
-    public ulong[] OwnerIds { get; set; } = new ulong[1];
-    public string LoLApiKey { get; set; } = string.Empty;
-    public string GoogleApiKey { get; set; } = string.Empty;
-    public string MashapeKey { get; set; } = string.Empty;
-    public string OsuApiKey { get; set; } = string.Empty;
-    public string CleverbotApiKey { get; set; } = string.Empty;
-    public string CarbonKey { get; set; } = string.Empty;
-    public int TotalShards { get; set; } = 1;
-    public string PatreonAccessToken { get; set; } = string.Empty;
-    public string PatreonCampaignId { get; set; } = "334038";
-    public RestartConfig RestartCommand { get; set; }
-
-    public string ShardRunCommand { get; set; } = string.Empty;
-    public string ShardRunArguments { get; set; } = string.Empty;
-    public int? ShardRunPort { get; set; }
-    public string MiningProxyUrl { get; set; } = string.Empty;
-    public string MiningProxyCreds { get; set; } = string.Empty;
-
-    public string BotListToken { get; set; } = string.Empty;
-    public string TwitchClientId { get; set; } = string.Empty;
-    public string VotesToken { get; set; } = string.Empty;
-    public string VotesUrl { get; set; } = string.Empty;
-    public string RedisOptions { get; set; } = string.Empty;
-    public string LocationIqApiKey { get; set; } = string.Empty;
-    public string TimezoneDbApiKey { get; set; } = string.Empty;
-    public string CoinmarketcapApiKey { get; set; } = string.Empty;
-
-    public class RestartConfig
-    {
-        public string Cmd { get; set; }
-        public string Args { get; set; }
-
-        public RestartConfig(string cmd, string args)
-        {
-            Cmd = cmd;
-            Args = args;
-        }
-    }
-}

src/NadekoBot/_common/Sender/ResponseBuilder.PaginationSender.cs

@@ -12,8 +12,8 @@ public partial class ResponseBuilder
         private readonly DiscordSocketClient _client;
         private int currentPage;
         
-        private NadekoButtonInteractionHandler left;
-        private NadekoButtonInteractionHandler right;
+        private NadekoButtonInteractionHandler? left;
+        private NadekoButtonInteractionHandler? right;
         private NadekoInteractionBase? extra;
 
         public PaginationSender(
@@ -71,7 +71,8 @@ public partial class ResponseBuilder
                         return Task.CompletedTask;
                     },
                     true,
-                    singleUse: false);
+                    singleUse: false,
+                    clearAfter: false);
 
                 if (_paginationBuilder.InteractionFunc is not null)
                 {
@@ -106,7 +107,8 @@ public partial class ResponseBuilder
                         return Task.CompletedTask;
                     },
                     true,
-                    singleUse: false);
+                    singleUse: false,
+                    clearAfter: false);
 
                 return (leftBtnInter, maybeInter, rightBtnInter);
             }
@@ -120,8 +122,8 @@ public partial class ResponseBuilder
                 if (_paginationBuilder.AddPaginatedFooter)
                     toSend.AddPaginatedFooter(currentPage, lastPage);
 
-                left.SetCompleted();
-                right.SetCompleted();
+                left?.SetCompleted();
+                right?.SetCompleted();
                 extra?.SetCompleted();
                 (left, extra, right) = (await GetInteractions());
 

src/NadekoBot/_common/_Extensions/Extensions.cs

@@ -229,10 +229,4 @@ public static class Extensions
     public static IEnumerable<IRole> GetRoles(this IGuildUser user)
         => user.RoleIds.Select(r => user.Guild.GetRole(r)).Where(r => r is not null);
 
-    // todo remove
-    public static void Lap(this Stopwatch sw, string checkpoint)
-    {
-        Log.Information("Checkpoint {CheckPoint}: {Time}ms", checkpoint, sw.Elapsed.TotalMilliseconds);
-        sw.Restart();
-    }
 }

src/NadekoBot/creds_example.yml

@@ -1,5 +1,5 @@
 # DO NOT CHANGE
-version: 7
+version: 9
 # Bot token. Do not share with anyone ever -> https://discordapp.com/developers/applications/
 token: ''
 # List of Ids of the users who have bot owner permissions
@@ -13,6 +13,12 @@ usePrivilegedIntents: true
 # note: If you are planning to have more than one shard, then you must change botCache to 'redis'.
 # Also, in that case you should be using NadekoBot.Coordinator to start the bot, and it will correctly override this value.
 totalShards: 1
+# Pledge 5$ or more on https://patreon.com/nadekobot and connect your discord account to Patreon.
+# Go to https://dashy.nadeko.bot/me and login with your discord account
+# Go to the Keys page and click "Generate New Key" and copy it here
+# You and anyone else with the permission to run `.prompt` command will be able to use natural language to run bot's commands.
+# For example '@Bot how's the weather in Paris' will return the current weather in Paris as if you were to run `.weather Paris` command.
+nadekoAiToken: 
 # Login to https://console.cloud.google.com, create a new project, go to APIs & Services -> Library -> YouTube Data API and enable it.
 # Then, go to APIs and Services -> Credentials and click Create credentials -> API key.
 # Used only for Youtube Data Api (at the moment).
@@ -56,7 +62,7 @@ patreon:
 botListToken: ''
 # Official cleverbot api key.
 cleverbotApiKey: ''
-# Official GPT-3 api key.
+# OpenAi api key.
 gpt3ApiKey: ''
 # Which cache implementation should bot use.
 # 'memory' - Cache will be in memory of the bot's process itself. Only use this on bots with a single shard. When the bot is restarted the cache is reset.

src/NadekoBot/data/aliases.yml

@@ -1400,4 +1400,6 @@ stickyroles:
 cleanupguilddata:
   - cleanupguilddata
 prompt:
-  - prompt
+  - prompt
+honeypot:
+  - honeypot

src/NadekoBot/data/strings/commands/commands.en-US.yml

@@ -4523,4 +4523,12 @@ prompt:
   params:
     - query:
         desc: "The message to send to the bot."
-    
+honeypot:
+  desc: |-
+    Toggles honeypot on the current channel.
+    Anyone sending a message in this channel will be soft banned. (Banned and then unbanned)
+    This is useful for automatically getting rid of spam bots.
+  ex:
+    - ''
+  params:
+    - {}

src/NadekoBot/data/strings/responses/responses.en-US.json

@@ -619,7 +619,7 @@
   "quote_deleted": "Quote #{0} deleted.",
   "quote_edited": "Quote Edited",
   "region": "Region",
-  "remind2": "I will remind {0} to {1} {2} ({3})`",
+  "remind2": "I will remind {0} to {1} {2} ({3})",
   "remind_timely": "I will remind you about your timely reward {0}",
   "remind_invalid": "Not a valid remind format. Remind must have a target, timer and a reason. Check the command list.",
   "remind_too_long": "Remind time has exceeded maximum.",
@@ -1101,5 +1101,7 @@
   "todo_archived_list": "Archived Todo List",
   "search_results": "Search results",
   "queue_search_results": "Type the number of the search result to queue up that track.",
-  "overloads": "Overloads"
+  "overloads": "Overloads",
+  "honeypot_on": "Honeypot enabled on this channel." ,
+  "honeypot_off": "Honeypot disabled."
 }